SoupSession::request-started is deprecated in libsoup 2.50. Both signals are equivalent, but SoupMessage::starting is also emitted for resources loaded from the disk cache. This fixes web timing calculations for cached resources, since we were not initializing m_requestStart.
Created attachment 247662 [details] Patch
Comment on attachment 247662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247662&action=review Makes sense. Any test that could start have started to pass due to this change? > Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:119 > #endif Pretty unfortunate to have the WebTiming stuff here. Hopefully we could remove it with the starting signal at some point.
(In reply to comment #2) > Comment on attachment 247662 [details] > Patch Thanks! > View in context: > https://bugs.webkit.org/attachment.cgi?id=247662&action=review > > Makes sense. Any test that could start have started to pass due to this > change? I've tried all webtiming tests in TestExpectations before the patch and all of them passed, so . . . Anyway, this only affects disk cached resources, so I guess that's not the case of any test. > > Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:119 > > #endif > > Pretty unfortunate to have the WebTiming stuff here. Hopefully we could > remove it with the starting signal at some point. Yes, indeed.
Committed r180928: <http://trac.webkit.org/changeset/180928>