I have had some crashes lately, where the IWebView parameter was NULL, causing an access violoation.
Created attachment 247660 [details] Patch
Comment on attachment 247660 [details] Patch Delegate callbacks should never be called with a null web view. I think you should try to figure out why it is null instead of adding a null-check.
(In reply to comment #2) > Comment on attachment 247660 [details] > Patch > > Delegate callbacks should never be called with a null web view. I think you > should try to figure out why it is null instead of adding a null-check. Ok, thanks for reviewing :) I will investigate why it happens.
Comment on attachment 247660 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247660&action=review > Source/WebKit/win/DefaultPolicyDelegate.cpp:106 > + Even though Anders doesn't like this check and return, it definitely seems like we should ASSERT here (or maybe even RELEASE_ASSERT?) so we can catch when this happens.
(In reply to comment #4) > Comment on attachment 247660 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=247660&action=review > > > Source/WebKit/win/DefaultPolicyDelegate.cpp:106 > > + > > Even though Anders doesn't like this check and return, it definitely seems > like we should ASSERT here (or maybe even RELEASE_ASSERT?) so we can catch > when this happens. Thanks :) I will add the ASSERT, and see if I can find the cause.