Bug 142135 - Fetch cache origins from the network process
Summary: Fetch cache origins from the network process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-28 13:12 PST by Anders Carlsson
Modified: 2015-02-28 13:53 PST (History)
1 user (show)

See Also:

Attachments
Patch (7.76 KB, patch)
2015-02-28 13:15 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (7.80 KB, patch)
2015-02-28 13:19 PST, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-02-28 13:12:30 PST 
Fetch cache origins from the network process
Comment 1 Anders Carlsson 2015-02-28 13:15:11 PST 
Created attachment 247610 [details]
Patch
Comment 2 WebKit Commit Bot 2015-02-28 13:17:51 PST 
Attachment 247610 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:262:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:289:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:304:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2015-02-28 13:19:48 PST 
Created attachment 247611 [details]
Patch
Comment 4 WebKit Commit Bot 2015-02-28 13:22:48 PST 
Attachment 247611 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:262:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:291:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:306:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 mitz 2015-02-28 13:47:37 PST 
Comment on attachment 247611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247611&action=review

> Source/WebKit2/NetworkProcess/NetworkProcess.cpp:262
> +static void fetchDiskCacheOrigins(SessionID sessionID, std::function<void (Vector<WebsiteData::Entry>)> completionHandler)

Why “origins” and not “entires”?

> Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:114
> +    if (dataTypes & WebsiteDataTypeDiskCache && !isNonPersistentStore)

The double negative is confusing. Why not change the boolean to isPersistentStore?
Comment 6 Anders Carlsson 2015-02-28 13:53:22 PST 
Committed r180841: <http://trac.webkit.org/changeset/180841>