Bug 142122 - Fullscreen video layers are off by one sometimes
Summary: Fullscreen video layers are off by one sometimes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-02-27 18:59 PST by Simon Fraser (smfr)
Modified: 2015-02-28 12:59 PST (History)
5 users (show)

See Also:


Attachments
Patch (37.92 KB, patch)
2015-02-27 19:03 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
For EWS (84.78 KB, patch)
2015-02-27 20:57 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
For EWS (46.31 KB, patch)
2015-02-27 22:19 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
For EWS (47.61 KB, patch)
2015-02-28 11:36 PST, Simon Fraser (smfr)
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-02-27 18:59:23 PST
Fullscreen video layers are off by one sometimes
Comment 1 Simon Fraser (smfr) 2015-02-27 19:03:33 PST
Created attachment 247580 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-02-27 19:06:33 PST
rdar://problem/19878821
Comment 3 Simon Fraser (smfr) 2015-02-27 20:57:30 PST
Created attachment 247587 [details]
For EWS
Comment 4 Simon Fraser (smfr) 2015-02-27 22:19:56 PST
Created attachment 247589 [details]
For EWS
Comment 5 Simon Fraser (smfr) 2015-02-28 11:36:14 PST
Created attachment 247606 [details]
For EWS
Comment 6 Eric Carlson 2015-02-28 12:32:47 PST
Comment on attachment 247606 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=247606&action=review

> Source/WebCore/ChangeLog:10
> +        isn't always integral (because of preserving pixel ratio etc). Fix all the media

Minor nit: "preserving pixel aspect ratio" would be more correct
Comment 7 Simon Fraser (smfr) 2015-02-28 12:59:30 PST
https://trac.webkit.org/r180839