Bug 142096 - Make ActiveDOMObject::canSuspend() pure virtual
Summary: Make ActiveDOMObject::canSuspend() pure virtual
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-02-27 13:12 PST by Chris Dumez
Modified: 2015-02-27 17:05 PST (History)
2 users (show)

See Also:

Attachments
Patch (54.38 KB, patch)
2015-02-27 13:15 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (54.36 KB, patch)
2015-02-27 13:22 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (55.16 KB, patch)
2015-02-27 13:45 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (56.06 KB, patch)
2015-02-27 15:02 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (56.01 KB, patch)
2015-02-27 15:50 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-02-27 13:12:49 PST 
Make ActiveDOMObject::canSuspend() pure virtual so that people at least try to provide an implementation for it. The default implementation was returning false unconditionally and thus was preventing pages from entering the PageCache.

Radar: <rdar://problem/19923085>
Comment 1 Chris Dumez 2015-02-27 13:15:49 PST 
Created attachment 247540 [details]
Patch
Comment 2 Chris Dumez 2015-02-27 13:22:10 PST 
Created attachment 247541 [details]
Patch
Comment 3 Chris Dumez 2015-02-27 13:45:18 PST 
Created attachment 247547 [details]
Patch
Comment 4 Chris Dumez 2015-02-27 15:02:01 PST 
Created attachment 247559 [details]
Patch
Comment 5 Chris Dumez 2015-02-27 15:50:19 PST 
Created attachment 247568 [details]
Patch
Comment 6 Chris Dumez 2015-02-27 17:05:42 PST 
Comment on attachment 247568 [details]
Patch

Clearing flags on attachment: 247568

Committed r180801: <http://trac.webkit.org/changeset/180801>
Comment 7 Chris Dumez 2015-02-27 17:05:52 PST 
All reviewed patches have been landed.  Closing bug.