Bug 142092 - Add infrastructure for handling website data in the network process
Summary: Add infrastructure for handling website data in the network process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-27 11:32 PST by Anders Carlsson
Modified: 2015-02-27 12:14 PST (History)
1 user (show)

See Also:

Attachments
Patch (19.32 KB, patch)
2015-02-27 11:46 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (18.56 KB, patch)
2015-02-27 11:51 PST, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-02-27 11:32:24 PST 
Add infrastructure for handling website data in the network process
Comment 1 Anders Carlsson 2015-02-27 11:46:46 PST 
Created attachment 247530 [details]
Patch
Comment 2 WebKit Commit Bot 2015-02-27 11:49:39 PST 
Attachment 247530 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:68:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:111:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:113:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:419:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:421:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:117:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:135:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 8 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2015-02-27 11:51:36 PST 
Created attachment 247531 [details]
Patch
Comment 4 WebKit Commit Bot 2015-02-27 11:52:34 PST 
Attachment 247531 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:68:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:111:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:113:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:419:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:421:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:117:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:135:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 8 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Andreas Kling 2015-02-27 12:08:40 PST 
Comment on attachment 247531 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247531&action=review

r=me

> Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:144
> +    Vector<SecurityOriginData> originData;
> +    for (auto& origin : origins)
> +        originData.append(SecurityOriginData::fromSecurityOrigin(*origin));

Could use reserveInitialCapacity + uncheckedAppend here.
Comment 6 Anders Carlsson 2015-02-27 12:14:40 PST 
Committed r180773: <http://trac.webkit.org/changeset/180773>