Bug 142080 - Implement ES6 StringIterator
Summary: Implement ES6 StringIterator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on: 141351
Blocks:
  Show dependency treegraph
 
Reported: 2015-02-27 02:25 PST by Yusuke Suzuki
Modified: 2015-03-05 10:27 PST (History)
6 users (show)

See Also:


Attachments
rev1 prototype (33.50 KB, patch)
2015-02-27 03:40 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
prototype rev2 (46.49 KB, patch)
2015-02-27 09:14 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (46.45 KB, patch)
2015-03-03 10:15 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (46.57 KB, patch)
2015-03-05 08:39 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2015-02-27 02:25:16 PST
Implement ES6 StringIterator
Comment 1 Yusuke Suzuki 2015-02-27 03:40:12 PST
Created attachment 247507 [details]
rev1 prototype

prototype. not including build configuration for OSX and Windows yet. And this patch requires https://bugs.webkit.org/show_bug.cgi?id=141351 change.
Comment 2 Yusuke Suzuki 2015-02-27 09:14:27 PST
Created attachment 247516 [details]
prototype rev2

Update for Windows / OSX build
Comment 3 WebKit Commit Bot 2015-03-02 04:07:08 PST
Attachment 247516 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/StringIteratorPrototype.cpp:42:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Yusuke Suzuki 2015-03-03 10:15:01 PST
Created attachment 247767 [details]
Patch
Comment 5 Filip Pizlo 2015-03-04 20:10:56 PST
Comment on attachment 247767 [details]
Patch

LGTM.  I can r+ once you're ready.
Comment 6 Yusuke Suzuki 2015-03-05 08:39:01 PST
Created attachment 247952 [details]
Patch
Comment 7 WebKit Commit Bot 2015-03-05 08:41:02 PST
Attachment 247952 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/StringIteratorPrototype.cpp:42:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Yusuke Suzuki 2015-03-05 08:42:40 PST
(In reply to comment #5)
> Comment on attachment 247767 [details]
> Patch
> 
> LGTM.  I can r+ once you're ready.

Great! I've landed https://trac.webkit.org/changeset/181077, rebased my patch and marked r? :D
Comment 9 Yusuke Suzuki 2015-03-05 09:41:49 PST
Comment on attachment 247952 [details]
Patch

Thank you!
Comment 10 WebKit Commit Bot 2015-03-05 10:27:52 PST
Comment on attachment 247952 [details]
Patch

Clearing flags on attachment: 247952

Committed r181084: <http://trac.webkit.org/changeset/181084>
Comment 11 WebKit Commit Bot 2015-03-05 10:27:57 PST
All reviewed patches have been landed.  Closing bug.