Bug 142073 - Web Inspector: Add a subtle blue background for selected console messages
Summary: Web Inspector: Add a subtle blue background for selected console messages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-02-26 20:11 PST by Nikita Vasilyev
Modified: 2015-02-26 21:32 PST (History)
8 users (show)

See Also:

Attachments
Animated GIF (481.27 KB, image/gif)
2015-02-26 20:11 PST, Nikita Vasilyev 		no flags Details
Patch (2.62 KB, patch)
2015-02-26 20:23 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2015-02-26 20:11:50 PST 
Created attachment 247487 [details]
Animated GIF

In addition to that, also add a subtle blue border.
Comment 1 Radar WebKit Bug Importer 2015-02-26 20:17:16 PST 
<rdar://problem/19981097>
Comment 2 Nikita Vasilyev 2015-02-26 20:23:56 PST 
Created attachment 247490 [details]
Patch
Comment 3 Timothy Hatcher 2015-02-26 20:45:59 PST 
Comment on attachment 247490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247490&action=review

> Source/WebInspectorUI/UserInterface/Views/LogContentView.css:70
> +    z-index: 10;

Why is the z-index needed?
Comment 4 Timothy Hatcher 2015-02-26 20:47:17 PST 
Very nice!
Comment 5 Nikita Vasilyev 2015-02-26 21:01:27 PST 
(In reply to comment #3)
> Comment on attachment 247490 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=247490&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/LogContentView.css:70
> > +    z-index: 10;
> 
> Why is the z-index needed?

To hide the gaps between the selection bars: https://cloudup.com/cDEHWAyp8AF
Comment 6 WebKit Commit Bot 2015-02-26 21:32:26 PST 
Comment on attachment 247490 [details]
Patch

Clearing flags on attachment: 247490

Committed r180725: <http://trac.webkit.org/changeset/180725>
Comment 7 WebKit Commit Bot 2015-02-26 21:32:30 PST 
All reviewed patches have been landed.  Closing bug.