Bug 142068 – Web Inspector: console.table with source code location look poor

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Created attachment 247480 [details]
[IMAGE] Issue

* SUMMARY
console.table with source code location look poor. See attached screenshot.

* STEPS TO REPRODUCE
1. Inspect http://www.clicktorelease.com/tools/augmented-console/
2. Click the logs on the page which trigger console.tables
  => table in inspector console looks poor

[Radar WebKit Bug Importer]

<rdar://problem/19980148>

[Nikita Vasilyev]

Created attachment 249373 [details]
Patch

[Nikita Vasilyev]

Created attachment 249374 [details]
Screenshot with the patch applied

[Timothy Hatcher]

Comment on attachment 249373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249373&action=review

> Source/WebInspectorUI/UserInterface/Views/LogContentView.css:316
> +.console-data-grid {
> +    clear: both;
> +}

Can't we just do .console-group-messages .data-grid { }? No need for another class name.

[Nikita Vasilyev]

Created attachment 249379 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 249379 [details]
Patch

Rejecting attachment 249379 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[Build Bot]

Comment on attachment 249379 [details]
Patch

Attachment 249379 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4828715959713792

New failing tests:
fast/regions/auto-size/autoheight-two-pass-layout-complex-002.html

[Build Bot]

Created attachment 249383 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[WebKit Commit Bot]

Comment on attachment 249379 [details]
Patch

Clearing flags on attachment: 249379

Committed r181961: <http://trac.webkit.org/changeset/181961>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.