Bug 142064 - The bool returning form of BytecodeGenerator::addVar() can be removed
Summary: The bool returning form of BytecodeGenerator::addVar() can be removed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 142067
Blocks: 141174
  Show dependency tree / graph
 
Reported: 2015-02-26 16:46 PST by Filip Pizlo
Modified: 2015-02-26 18:28 PST (History)
3 users (show)

See Also:

Attachments
the patch (3.72 KB, patch)
2015-02-26 16:51 PST, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
patch for commit of assertion failure fix. (1.42 KB, patch)
2015-02-26 18:05 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-02-26 16:46:22 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2015-02-26 16:51:14 PST 
Created attachment 247467 [details]
the patch
Comment 2 WebKit Commit Bot 2015-02-26 16:52:21 PST 
Attachment 247467 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:616:  The parameter name "ident" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:616:  The parameter name "constantMode" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:616:  The parameter name "watchMode" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2015-02-26 16:52:54 PST 
Comment on attachment 247467 [details]
the patch

r=me
Comment 4 Filip Pizlo 2015-02-26 16:55:59 PST 
Landed in http://trac.webkit.org/changeset/180711
Comment 5 Brent Fulgham 2015-02-26 17:12:24 PST 
This may have caused a bunch of Debug assertions Windows. I'm trying to debug locally.
Comment 6 WebKit Commit Bot 2015-02-26 17:58:52 PST 
Re-opened since this is blocked by bug 142067
Comment 7 Mark Lam 2015-02-26 18:05:44 PST 
Created attachment 247478 [details]
patch for commit of assertion failure fix.
Comment 8 Mark Lam 2015-02-26 18:08:42 PST 
Fix for assertion failure landed in r180719: <http://trac.webkit.org/r180719>.
Comment 9 Filip Pizlo 2015-02-26 18:28:29 PST 
(In reply to comment #8)
> Fix for assertion failure landed in r180719:
> <http://trac.webkit.org/r180719>.

Thanks!