Bug 142062 - [Content Filtering] Move WebFilterEvaluator and NEFilterSource declarations to SPI headers
Summary: [Content Filtering] Move WebFilterEvaluator and NEFilterSource declarations t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks: 128858
  Show dependency tree / graph
 
Reported: 2015-02-26 15:46 PST by Andy Estes
Modified: 2015-02-26 16:09 PST (History)
3 users (show)

See Also:

Attachments
Patch (15.36 KB, patch)
2015-02-26 15:50 PST, Andy Estes 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2015-02-26 15:46:48 PST 
[Content Filtering] Move WebFilterEvaluator and NEFilterSource declarations to SPI headers
Comment 1 Andy Estes 2015-02-26 15:50:24 PST 
Created attachment 247456 [details]
Patch
Comment 2 WebKit Commit Bot 2015-02-26 15:53:47 PST 
Attachment 247456 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/cocoa/WebFilterEvaluatorSPI.h:36:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Daniel Bates 2015-02-26 16:00:30 PST 
Comment on attachment 247456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247456&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:24163
> +				A19D93411A9FE03300B46C24 /* WebFilterEvaluatorSPI.h in Headers */,

Please add this entry such that it is in this list of files in sorted order according to the UNIX sort command.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:25479
> +				A19D93431A9FE26200B46C24 /* NEFilterSourceSPI.h in Headers */,

Ditto.

> Source/WebCore/platform/spi/cocoa/NEFilterSourceSPI.h:27
> +#ifndef NEFilterSourceSPI_h
> +#define NEFilterSourceSPI_h

From my understanding we assume that an Objective-C header will be included using the #import directive. So, these header-guard macros are not necessary.

> Source/WebCore/platform/spi/cocoa/WebFilterEvaluatorSPI.h:27
> +#ifndef WebFilterEvaluatorSPI_h
> +#define WebFilterEvaluatorSPI_h

Ditto.
Comment 4 Andy Estes 2015-02-26 16:09:26 PST 
Committed r180708: <http://trac.webkit.org/changeset/180708>