Bug 142062 – [Content Filtering] Move WebFilterEvaluator and NEFilterSource declarations to SPI headers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[Content Filtering] Move WebFilterEvaluator and NEFilterSource declarations to SPI headers

[Andy Estes]

Created attachment 247456 [details]
Patch

[WebKit Commit Bot]

Attachment 247456 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/cocoa/WebFilterEvaluatorSPI.h:36:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

Comment on attachment 247456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247456&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:24163
> +				A19D93411A9FE03300B46C24 /* WebFilterEvaluatorSPI.h in Headers */,

Please add this entry such that it is in this list of files in sorted order according to the UNIX sort command.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:25479
> +				A19D93431A9FE26200B46C24 /* NEFilterSourceSPI.h in Headers */,

Ditto.

> Source/WebCore/platform/spi/cocoa/NEFilterSourceSPI.h:27
> +#ifndef NEFilterSourceSPI_h
> +#define NEFilterSourceSPI_h

From my understanding we assume that an Objective-C header will be included using the #import directive. So, these header-guard macros are not necessary.

> Source/WebCore/platform/spi/cocoa/WebFilterEvaluatorSPI.h:27
> +#ifndef WebFilterEvaluatorSPI_h
> +#define WebFilterEvaluatorSPI_h

Ditto.

[Andy Estes]

Committed r180708: <http://trac.webkit.org/changeset/180708>