Bug 142060 - Add API to remove all website data for the given data records
Summary: Add API to remove all website data for the given data records
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-26 14:56 PST by Anders Carlsson
Modified: 2015-02-26 15:34 PST (History)
3 users (show)

See Also:

Attachments
Patch (12.64 KB, patch)
2015-02-26 15:19 PST, Anders Carlsson 		bdakin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-02-26 14:56:35 PST 
Add API to remove all website data for the given data records
Comment 1 Anders Carlsson 2015-02-26 15:19:52 PST 
Created attachment 247453 [details]
Patch
Comment 2 WebKit Commit Bot 2015-02-26 15:23:29 PST 
Attachment 247453 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:334:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:337:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:362:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2015-02-26 15:31:41 PST 
Comment on attachment 247453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247453&action=review

> Source/WebCore/ChangeLog:10
> +        New function that removes resources all resources that match the set of origins in a given session.

Some kind of typo in the middle of this sentence.

> Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:108
> +

no blank line here
Comment 4 Beth Dakin 2015-02-26 15:32:23 PST 
Comment on attachment 247453 [details]
Patch

Listen to thorton!!!
Comment 5 Anders Carlsson 2015-02-26 15:34:33 PST 
Committed r180706: <http://trac.webkit.org/changeset/180706>