Bug 142057 - Fix the !ENABLE(WEBGL) build after r180609
Summary: Fix the !ENABLE(WEBGL) build after r180609
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Windows XP
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 141567
  Show dependency tree / graph
 
Reported: 2015-02-26 14:41 PST by Csaba Osztrogonác
Modified: 2015-03-09 13:52 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.62 KB, patch)
2015-02-26 14:44 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-02-26 14:41:25 PST 
log:

lib/libwebcore_efl.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp.o):GraphicsContext3DOpenGLCommon.cpp:function WebCore::GraphicsContext3D::forceContextLost(): error: undefined reference to 'WebCore::WebGLRenderingContextBase::forceLostContext(WebCore::WebGLRenderingContextBase::LostContextMode)'
collect2: error: ld returned 1 exit status

The problem is that forceLostContext() is defined inside ENABLE(WEBGL) guard, but used
unconditionally in GraphicsContext3DOpenGLCommon.cpp after http://trac.webkit.org/changeset/180609
Comment 1 Csaba Osztrogonác 2015-02-26 14:44:38 PST 
Created attachment 247447 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-03-05 01:50:51 PST 
Dean or Roger, could you possibly review the patch 
fixes the build breakage your patch caused?
Comment 3 Csaba Osztrogonác 2015-03-06 09:42:00 PST 
ping?
Comment 4 WebKit Commit Bot 2015-03-09 13:52:35 PDT 
Comment on attachment 247447 [details]
Patch

Clearing flags on attachment: 247447

Committed r181281: <http://trac.webkit.org/changeset/181281>
Comment 5 WebKit Commit Bot 2015-03-09 13:52:40 PDT 
All reviewed patches have been landed.  Closing bug.