Bug 142047 - Make WKPageGroupRemoveAllUserContentFilters actually remove all user content filters
Summary: Make WKPageGroupRemoveAllUserContentFilters actually remove all user content ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-26 11:05 PST by Brady Eidson
Modified: 2015-02-26 11:30 PST (History)
1 user (show)

See Also:

Attachments
Patch v1 (2.41 KB, patch)
2015-02-26 11:10 PST, Brady Eidson 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-02-26 11:05:35 PST 
Make WKPageGroupRemoveAllUserContentFilters actually remote all user content filters

http://trac.webkit.org/changeset/178869 added this SPI but implemented it incorrectly.
Comment 1 Brady Eidson 2015-02-26 11:10:48 PST 
Created attachment 247433 [details]
Patch v1
Comment 2 Geoffrey Garen 2015-02-26 11:28:05 PST 
Comment on attachment 247433 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=247433&action=review

r=me

Plz fix tyop.

> LayoutTests/ChangeLog:3
> +        Make WKPageGroupRemoveAllUserContentFilters actually remote all user content filters

Should be "remove".

> Source/WebKit2/ChangeLog:3
> +        Make WKPageGroupRemoveAllUserContentFilters actually remote all user content filters

Should be "remove".

> Source/WebKit2/UIProcess/API/C/WKPageGroup.cpp:95
> +    toImpl(pageGroupRef)->removeAllUserContentFilters();

lol
Comment 3 Brady Eidson 2015-02-26 11:30:19 PST 
http://trac.webkit.org/changeset/180687