Bug 142043 – [webkitpy] Remove unused functions from git.py

• Status: RESOLVED
• Resolution: INVALID
• Component: New Bugs

[Csaba Osztrogonác]

[webkitpy] Remove unused functions from git.py

[Csaba Osztrogonác]

Created attachment 247423 [details]
Patch

[Csaba Osztrogonác]

These functions were added by http://trac.webkit.org/changeset/175606
and http://trac.webkit.org/changeset/175605 , but weren't used ever.

Let's remove them.

[Ryosuke Niwa]

Comment on attachment 247423 [details]
Patch

Oh, I think these are used by Apple internal tools.

[Csaba Osztrogonác]

It would be great to have a reference to it somewhere.

[Matthew Hanson]

I hear what you're saying, Csaba. But can't it also be useful in and of itself? E.g. for use in personal workflow automation scripts?

The git.py module is supposed to be an interface to the Git tool, and cherrypick merging is something that a person with a merge-based workflow would use fairly often.

[Csaba Osztrogonác]

(In reply to comment #5)
> I hear what you're saying, Csaba. But can't it also be useful in and of
> itself? E.g. for use in personal workflow automation scripts?

Of course it can be. But I thought git.py is only used by 
webkitpy scripts, that's why thought it is unused.

> The git.py module is supposed to be an interface to the Git tool, and
> cherrypick merging is something that a person with a merge-based workflow
> would use fairly often.

See.

I could imagine a publicly available webkit-patch cherry-pick <svn-revision> 
command. I assume you use these functions for similar use-case.