Bug 142043 - [webkitpy] Remove unused functions from git.py
Summary: [webkitpy] Remove unused functions from git.py
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-26 06:06 PST by Csaba Osztrogonác
Modified: 2015-02-26 10:29 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.12 KB, patch)
2015-02-26 06:06 PST, Csaba Osztrogonác
rniwa: review-
rniwa: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-02-26 06:06:01 PST
[webkitpy] Remove unused functions from git.py
Comment 1 Csaba Osztrogonác 2015-02-26 06:06:15 PST
Created attachment 247423 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-02-26 06:08:44 PST
These functions were added by http://trac.webkit.org/changeset/175606
and http://trac.webkit.org/changeset/175605 , but weren't used ever.

Let's remove them.
Comment 3 Ryosuke Niwa 2015-02-26 09:39:12 PST
Comment on attachment 247423 [details]
Patch

Oh, I think these are used by Apple internal tools.
Comment 4 Csaba Osztrogonác 2015-02-26 09:41:38 PST
It would be great to have a reference to it somewhere.
Comment 5 Matthew Hanson 2015-02-26 10:19:42 PST
I hear what you're saying, Csaba. But can't it also be useful in and of itself? E.g. for use in personal workflow automation scripts?

The git.py module is supposed to be an interface to the Git tool, and cherrypick merging is something that a person with a merge-based workflow would use fairly often.
Comment 6 Csaba Osztrogonác 2015-02-26 10:29:12 PST
(In reply to comment #5)
> I hear what you're saying, Csaba. But can't it also be useful in and of
> itself? E.g. for use in personal workflow automation scripts?

Of course it can be. But I thought git.py is only used by 
webkitpy scripts, that's why thought it is unused.

> The git.py module is supposed to be an interface to the Git tool, and
> cherrypick merging is something that a person with a merge-based workflow
> would use fairly often.

See.

I could imagine a publicly available webkit-patch cherry-pick <svn-revision> 
command. I assume you use these functions for similar use-case.