Bug 142039 - Remove unnecessary create() factory functions
Summary: Remove unnecessary create() factory functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-26 00:03 PST by Gyuyoung Kim
Modified: 2015-02-26 22:19 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.75 KB, patch)
2015-02-26 00:05 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (6.96 KB, patch)
2015-02-26 17:06 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-02-26 00:03:42 PST 
SSIA
Comment 1 Gyuyoung Kim 2015-02-26 00:05:30 PST 
Created attachment 247411 [details]
Patch
Comment 2 Chris Dumez 2015-02-26 10:11:01 PST 
Comment on attachment 247411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247411&action=review

r=me

> Source/WebCore/Modules/webdatabase/DatabaseThread.cpp:108
> +    explicit DatabaseUnpauseTask(DatabaseThread* thread)

nit: This could take a DatabaseThread&

> Source/WebCore/Modules/webdatabase/DatabaseThread.cpp:110
> +        , m_thread(thread)

nit: m_thread could be a reference.
Comment 3 Gyuyoung Kim 2015-02-26 17:06:53 PST 
Created attachment 247470 [details]
Patch
Comment 4 WebKit Commit Bot 2015-02-26 17:56:57 PST 
Comment on attachment 247470 [details]
Patch

Clearing flags on attachment: 247470

Committed r180717: <http://trac.webkit.org/changeset/180717>
Comment 5 WebKit Commit Bot 2015-02-26 17:57:01 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Alexey Proskuryakov 2015-02-26 22:07:23 PST 
iOS build fix in r180727.

Why wasn't this patch processed by EWS?
Comment 7 Gyuyoung Kim 2015-02-26 22:19:10 PST 
(In reply to comment #6)
> iOS build fix in r180727.
> 
> Why wasn't this patch processed by EWS?

Oh, I'm sorry. I thought that build will be fine. I just upload a fix to Bug 142077. Let me land it after passing ios ews. I'm sorry again.