WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
142034
[Win] Make build logs more legible by reducing noise
https://bugs.webkit.org/show_bug.cgi?id=142034
Summary
[Win] Make build logs more legible by reducing noise
Brent Fulgham
Reported
2015-02-25 17:52:58 PST
Our Windows build logs produce a tremendous amount of boilerplate output and detailed build state that makes it very difficult to find and understand why the build has failed. We can improve things as follows: 1. Update our batch file (Windows CMD files) to use the '@' character as the first character on each line. This will prevent these lines from being echoed into our build logs. 2. Pass the '/Q' flag to our invocations of CMD so that they run silently. This will reduce another set of output that we generally do not care about. 3. Pipe the output of XCOPY to "NUL". This will hide the file copy state, but we have not generally found these messages to be helpful when debugging build errors, even when they have been caused by files not being copied.
Attachments
Patch
(55.47 KB, patch)
2015-02-25 22:54 PST
,
Brent Fulgham
ap
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2015-02-25 22:54:42 PST
Created
attachment 247410
[details]
Patch
Brent Fulgham
Comment 2
2015-02-25 23:04:47 PST
The patch seems to be failing on the Windows EWS bot, I believe due to EOL differences. Unfortunately, I can't tell from the log (which is ironic, since the point of this patch is to fix this problem).
Alexey Proskuryakov
Comment 3
2015-02-25 23:35:09 PST
Comment on
attachment 247410
[details]
Patch rs=me
Brent Fulgham
Comment 4
2015-02-26 08:51:25 PST
Committed
r180676
: <
http://trac.webkit.org/changeset/180676
>
Brent Fulgham
Comment 5
2015-02-26 10:20:29 PST
I missed an important set of changes to {Pre|Post}{Build|Link} steps. This was committed in
r180680
<
https://trac.webkit.org/changeset/180680
>.
Radar WebKit Bug Importer
Comment 6
2015-02-27 10:21:02 PST
<
rdar://problem/19985941
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug