Bug 142022 - DFG abstract heaps should respect difference between heap and stack
Summary: DFG abstract heaps should respect difference between heap and stack
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-25 13:38 PST by Filip Pizlo
Modified: 2015-02-25 20:29 PST (History)
0 users

See Also:


Attachments
the patch (16.01 KB, patch)
2015-02-25 13:40 PST, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-02-25 13:38:07 PST
We will soon be in a world where a "world clobbering" operation cannot write to our stack, but may be able to read from it.  This means that we need to change the DFG abstract heap hierarchy to have a notion of Heap that subsumes all that World previously subsumed, and a new notion of Stack that is a subtype of World and a sibling of Heap.
Comment 1 Filip Pizlo 2015-02-25 13:40:53 PST
Created attachment 247339 [details]
the patch
Comment 2 Geoffrey Garen 2015-02-25 13:45:47 PST
Comment on attachment 247339 [details]
the patch

r=me
Comment 3 Filip Pizlo 2015-02-25 20:29:57 PST
Landed in http://trac.webkit.org/changeset/180656