Bug 142021 - Get rid of TestInvocation::pathOrURL
Summary: Get rid of TestInvocation::pathOrURL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-25 13:14 PST by Brady Eidson
Modified: 2015-02-25 13:28 PST (History)
0 users

See Also:

Attachments
Patch v1 (11.13 KB, patch)
2015-02-25 13:19 PST, Brady Eidson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-02-25 13:14:03 PST 
Get rid of TestInvocation::pathOrURL

When running tests using `run-webkit-tests`, the pathOrURL string is always an absolute path.

But when running tests using `WebKitTestRunner <path to test>`, the pathOrURL string can be a relative path.

If you are inside a "special" directory and invoke WebKitTestRunner directly on a test in that directory, then the pathOrURL string does NOT contain that directory name.

Therefore, special behavior based on the directory name does not take place.

The pathOrURL string never really needs to be exposed, so this is a pretty good cleanup.
Comment 1 Brady Eidson 2015-02-25 13:19:07 PST 
Created attachment 247337 [details]
Patch v1
Comment 2 Brady Eidson 2015-02-25 13:28:07 PST 
http://trac.webkit.org/changeset/180636