Bug 142018 – Layout test support for user content filters

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Layout test support for user content filters

As we work on the feature, we'll need tests.

[Brady Eidson]

Created attachment 247335 [details]
Patch v1

[Tim Horton]

Comment on attachment 247335 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=247335&action=review

> LayoutTests/platform/gtk/TestExpectations:2341
> +http/tests/usercontentfilter [ Skip ]

You could skip in the global TestExpectations and unskip in Mac WK2 if you wanted to make less of a mess.

> Tools/WebKitTestRunner/mac/TestControllerMac.mm:104
> +    char urlCString[16384];
> +    WKStringGetUTF8CString(urlString.get(), urlCString, 16384);

This is pretty lazy :D

[Brady Eidson]

(In reply to comment #2)
> Comment on attachment 247335 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=247335&action=review
> 
> > LayoutTests/platform/gtk/TestExpectations:2341
> > +http/tests/usercontentfilter [ Skip ]
> 
> You could skip in the global TestExpectations and unskip in Mac WK2 if you
> wanted to make less of a mess.

Oh boy, will I ever!

> > Tools/WebKitTestRunner/mac/TestControllerMac.mm:104
> > +    char urlCString[16384];
> > +    WKStringGetUTF8CString(urlString.get(), urlCString, 16384);
> 
> This is pretty lazy :D

As discussed on IRC, the commonly used alternative of using pathOrURL() breaks down when you are running WKTR directly from within the directory where the test resides.

I'll maybe fix up the other sites that use that approach, in a separate patch :)

[Brady Eidson]

http://trac.webkit.org/changeset/180633