Bug 142010 - Web Inspector: Improve Regex/Error output in Object Tree and Previews
Summary: Web Inspector: Improve Regex/Error output in Object Tree and Previews
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-02-25 00:10 PST by Joseph Pecoraro
Modified: 2015-02-25 07:10 PST (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (5.76 KB, patch)
2015-02-25 00:16 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (6.88 KB, patch)
2015-02-25 00:23 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-02-25 00:10:33 PST
* SUMMARY
Improve Regex/Error output in Object Tree and Previews.

  - Regex objects:
    - show lots of properties in previews that are not particularly useful
    - show as black in previews, instead of orange
    - show as black in object tree, instead of orange, when expanded to show properties
      => the formatted value (orange) "/foo/g" would be nicer always when visible

  - Error objects:
    - show lots of properties in previews that are not particularly useful
    - should be expandable to show properties
Comment 1 Radar WebKit Bug Importer 2015-02-25 00:11:04 PST
<rdar://problem/19950119>
Comment 2 Joseph Pecoraro 2015-02-25 00:16:13 PST
Created attachment 247319 [details]
[PATCH] Proposed Fix

RegExps look way better with this.
Comment 3 Joseph Pecoraro 2015-02-25 00:23:31 PST
Created attachment 247320 [details]
[PATCH] Proposed Fix

Even better, this applies the same "titleElement" improvement to ObjectTree without preview.

This makes it so:

  js> dir(null)
  js> dir(100)
  js> dir(true)

And friends show an Object Tree with a formatted value in the title, instead of black text.
Comment 4 Timothy Hatcher 2015-02-25 06:26:26 PST
Comment on attachment 247320 [details]
[PATCH] Proposed Fix

Nice!
Comment 5 WebKit Commit Bot 2015-02-25 07:10:23 PST
Comment on attachment 247320 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 247320

Committed r180625: <http://trac.webkit.org/changeset/180625>
Comment 6 WebKit Commit Bot 2015-02-25 07:10:27 PST
All reviewed patches have been landed.  Closing bug.