Bug 142008 - Web Inspector: Improve PropertyPath display strings for getters / values
Summary: Web Inspector: Improve PropertyPath display strings for getters / values
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
Keywords: InRadar
Depends on:
Reported: 2015-02-24 23:14 PST by Joseph Pecoraro
Modified: 2015-02-25 07:04 PST (History)
8 users (show)

See Also:

[PATCH] Proposed Fix (9.76 KB, patch)
2015-02-24 23:18 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-02-24 23:14:06 PST
Improve PropertyPath display strings for getters / values.

  js> dir([{property: {get value() { return 10; }}}])
  <-  ▼ 0: Object
        ▼ property: Object
          ▼ value: (...)

Hovering value here should say:

Once invoking the getter. Hovering value should say:


We should elide __proto__ when dealing with values. We could probably keep them for getters, but lets leave them in to guarentee the absolute path.
Comment 1 Radar WebKit Bug Importer 2015-02-24 23:14:18 PST
Comment 2 Joseph Pecoraro 2015-02-24 23:18:36 PST
Created attachment 247315 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2015-02-25 07:04:06 PST
Comment on attachment 247315 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 247315

Committed r180624: <http://trac.webkit.org/changeset/180624>
Comment 4 WebKit Commit Bot 2015-02-25 07:04:11 PST
All reviewed patches have been landed.  Closing bug.