Bug 142004 - AX: Implement support for ARIA 1.1 'searchbox' role
Summary: AX: Implement support for ARIA 1.1 'searchbox' role
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joanmarie Diggs (irc: joanie)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-02-24 21:40 PST by Joanmarie Diggs (irc: joanie)
Modified: 2015-02-25 02:04 PST (History)
3 users (show)

See Also:


Attachments
Patch (15.14 KB, patch)
2015-02-24 22:04 PST, Joanmarie Diggs (irc: joanie)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joanmarie Diggs (irc: joanie) 2015-02-24 21:40:45 PST
ARIA 1.1 has a new 'searchbox' role. We need to implement support for it.
Comment 1 Radar WebKit Bug Importer 2015-02-24 21:41:07 PST
<rdar://problem/19949292>
Comment 2 Joanmarie Diggs (irc: joanie) 2015-02-24 22:04:22 PST
Created attachment 247311 [details]
Patch
Comment 3 Joanmarie Diggs (irc: joanie) 2015-02-24 22:09:19 PST
As is becoming tradition, not yet asking for review while EWS sanity checks my Mavericks and iOS changes. (I'll set up a Mavericks box; can't do much about iOS...)

Also, this patch doesn't include any hierarchical/children tests. I was going to do so, but discovered that we're (perhaps) not doing sufficient sanity checking on children. This is true for the already-implemented ARIA textbox role, and I'm not sure what the right thing to do is, so I opened bug 142005 for that.
Comment 4 Joanmarie Diggs (irc: joanie) 2015-02-24 23:27:14 PST
(In reply to comment #3)
> As is becoming tradition, not yet asking for review while EWS sanity checks
> my Mavericks and iOS changes. (I'll set up a Mavericks box; can't do much
> about iOS...)

Huh. Just found https://www.webkit.org/blog/3457/building-webkit-for-ios-simulator/. Ok, maybe I *can* do much about iOS. ;) I'll add that to my list.

In the meantime, Chris, I just made an educated guess based on what you asked me to do for the switch role. Please review. Thanks!
Comment 5 WebKit Commit Bot 2015-02-25 02:04:33 PST
Comment on attachment 247311 [details]
Patch

Clearing flags on attachment: 247311

Committed r180621: <http://trac.webkit.org/changeset/180621>
Comment 6 WebKit Commit Bot 2015-02-25 02:04:36 PST
All reviewed patches have been landed.  Closing bug.