Bug 141997 - Cleanup BackgroundImageGeometry class.
Summary: Cleanup BackgroundImageGeometry class.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-24 19:38 PST by zalan
Modified: 2015-02-25 15:19 PST (History)
7 users (show)

See Also:


Attachments
Patch (18.40 KB, patch)
2015-02-24 19:53 PST, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-mavericks (3.15 MB, application/zip)
2015-02-24 20:50 PST, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (1.71 MB, application/zip)
2015-02-24 20:51 PST, Build Bot
no flags Details
Patch (18.68 KB, patch)
2015-02-25 13:48 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-02-24 19:38:47 PST
and RenderBoxModelObject::calculateBackgroundImageGeometry.
Comment 1 zalan 2015-02-24 19:53:05 PST
Created attachment 247297 [details]
Patch
Comment 2 Build Bot 2015-02-24 20:50:37 PST
Comment on attachment 247297 [details]
Patch

Attachment 247297 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6070849257865216

New failing tests:
fast/backgrounds/hidpi-bitmap-background-repeat-on-subpixel-position.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-003.html
imported/mozilla/svg/as-image/background-stretch-1.html
ietestcenter/css3/flexbox/flexbox-pack-center-001.htm
css3/masking/mask-repeat-space-border.html
css3/background/background-repeat-space-padding.html
css3/masking/mask-repeat-round-auto2.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001.html
css3/background/background-repeat-round-auto2.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-002.html
css3/background/background-repeat-space-border.html
ietestcenter/css3/flexbox/flexbox-align-baseline-001.htm
ietestcenter/css3/flexbox/flexbox-flex-001.htm
css3/masking/mask-svg-clipped-fragmentId.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-001.html
css3/masking/mask-repeat-space-padding.html
fast/css/cascade/background-origin-and-webkit-background-origin-cascade-order.html
fast/backgrounds/hidpi-bitmap-background-origin-on-subpixel-position.html
fast/backgrounds/background-position-rendering.html
fast/shapes/shape-outside-floats/shape-outside-image-set.html
css3/masking/mask-repeat-space-content.html
css3/masking/mask-base64.html
Comment 3 Build Bot 2015-02-24 20:50:40 PST
Created attachment 247305 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-02-24 20:51:12 PST
Comment on attachment 247297 [details]
Patch

Attachment 247297 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5389136043180032

New failing tests:
css3/masking/mask-repeat-space-padding.html
css3/masking/mask-svg-clipped-fragmentId.html
fast/backgrounds/background-position-rendering.html
fast/backgrounds/hidpi-bitmap-background-repeat-on-subpixel-position.html
css3/background/background-repeat-space-padding.html
css3/masking/mask-repeat-round-auto2.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001.html
ietestcenter/css3/flexbox/flexbox-flex-001.htm
imported/mozilla/svg/as-image/background-stretch-1.html
css3/masking/mask-base64.html
css3/background/background-repeat-round-auto2.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-002.html
ietestcenter/css3/flexbox/flexbox-pack-center-001.htm
css3/masking/mask-repeat-space-content.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-001.html
css3/background/background-repeat-space-border.html
ietestcenter/css3/flexbox/flexbox-align-baseline-001.htm
fast/css/cascade/background-origin-and-webkit-background-origin-cascade-order.html
fast/backgrounds/hidpi-bitmap-background-origin-on-subpixel-position.html
fast/shapes/shape-outside-floats/shape-outside-image-set.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-003.html
Comment 5 Build Bot 2015-02-24 20:51:16 PST
Created attachment 247306 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 zalan 2015-02-25 13:48:27 PST
Created attachment 247342 [details]
Patch
Comment 7 Simon Fraser (smfr) 2015-02-25 14:19:51 PST
Comment on attachment 247342 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247342&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1164
> +        phase.setWidth(tileSize.width() ? tileSize.width() -  fmodf(computedXPosition + left, tileSize.width()): 0);

two spaces
Comment 8 WebKit Commit Bot 2015-02-25 15:19:35 PST
Comment on attachment 247342 [details]
Patch

Clearing flags on attachment: 247342

Committed r180644: <http://trac.webkit.org/changeset/180644>
Comment 9 WebKit Commit Bot 2015-02-25 15:19:39 PST
All reviewed patches have been landed.  Closing bug.