ARIA 1.1 has a new 'switch' role. We need to support it. http://rawgit.com/w3c/aria/master/aria/aria.html#switch
<rdar://problem/19944239>
Created attachment 247269 [details] Patch
Not yet asking for review. Using EWS to verify the Mavericks result since I don't have a Mavericks system and the Switch subrole is new to OS X.
Comment on attachment 247269 [details] Patch Attachment 247269 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5822384426713088 New failing tests: accessibility/roles-exposed.html
Created attachment 247272 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Created attachment 247274 [details] Patch
Chris: Could you please review this when you have chance? Thanks!
Comment on attachment 247274 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247274&action=review > Source/WebCore/ChangeLog:18 > + * accessibility/AccessibilityNodeObject.cpp: For iOS, can you add SwitchRole to the list in determineIsAccessibilityElement accessibilityCanFuzzyHitTest accessibilityTraits - > under CheckBoxRole > Source/WebCore/accessibility/AccessibilityObject.h:503 > + virtual bool isSwitch() const { return roleValue() == SwitchRole; } this probably doesn't need to be virtual
Created attachment 247279 [details] Patch
Comment on attachment 247279 [details] Patch looks good. thanks
Comment on attachment 247279 [details] Patch Clearing flags on attachment: 247279 Committed r180600: <http://trac.webkit.org/changeset/180600>
All reviewed patches have been landed. Closing bug.
This caused several Windows layout test failures. Can someone please review and resolve this? Otherwise, I will roll it out.
We need Windows EWS to run tests so this doesn't happen.