Bug 141986 – AX: Implement support for ARIA 1.1 'switch' role

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

ARIA 1.1 has a new 'switch' role. We need to support it.
http://rawgit.com/w3c/aria/master/aria/aria.html#switch

[Radar WebKit Bug Importer]

<rdar://problem/19944239>

[Joanmarie Diggs]

Created attachment 247269 [details]
Patch

[Joanmarie Diggs]

Not yet asking for review. Using EWS to verify the Mavericks result since I don't have a Mavericks system and the Switch subrole is new to OS X.

[Build Bot]

Comment on attachment 247269 [details]
Patch

Attachment 247269 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5822384426713088

New failing tests:
accessibility/roles-exposed.html

[Build Bot]

Created attachment 247272 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Joanmarie Diggs]

Created attachment 247274 [details]
Patch

[Joanmarie Diggs]

Chris: Could you please review this when you have chance? Thanks!

[chris fleizach]

Comment on attachment 247274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247274&action=review

> Source/WebCore/ChangeLog:18
> +        * accessibility/AccessibilityNodeObject.cpp:

For iOS, can you add SwitchRole to the list in
determineIsAccessibilityElement
accessibilityCanFuzzyHitTest
accessibilityTraits - > under CheckBoxRole

> Source/WebCore/accessibility/AccessibilityObject.h:503
> +    virtual bool isSwitch() const { return roleValue() == SwitchRole; }

this probably doesn't need to be virtual

[Joanmarie Diggs]

Created attachment 247279 [details]
Patch

[chris fleizach]

Comment on attachment 247279 [details]
Patch

looks good. thanks

[WebKit Commit Bot]

Comment on attachment 247279 [details]
Patch

Clearing flags on attachment: 247279

Committed r180600: <http://trac.webkit.org/changeset/180600>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Brent Fulgham]

This caused several Windows layout test failures. Can someone please review and resolve this? Otherwise, I will roll it out.

[Brent Fulgham]

We need Windows EWS to run tests so this doesn't happen.