Bug 141985 - Use an enum for scrollbar style
Summary: Use an enum for scrollbar style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-24 14:52 PST by Simon Fraser (smfr)
Modified: 2015-02-24 20:08 PST (History)
2 users (show)

See Also:

Attachments
Patch (15.09 KB, patch)
2015-02-24 14:54 PST, Simon Fraser (smfr) 		bdakin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-02-24 14:52:58 PST 
Use an enum for scrollbar style
Comment 1 Simon Fraser (smfr) 2015-02-24 14:54:19 PST 
Created attachment 247268 [details]
Patch
Comment 2 Beth Dakin 2015-02-24 15:01:12 PST 
Comment on attachment 247268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247268&action=review

> Source/WebCore/platform/ScrollTypes.h:159
> +        Normal,

I object!!! I think that overlay is definitely the new normal. Legacy would be more appropriate. Alternatively, maybe something like Physical? Permanent? SpaceOccupying? AlwaysVisible? None of these are very good, but I definitely object to Normal.
Comment 3 Simon Fraser (smfr) 2015-02-24 20:08:01 PST 
https://trac.webkit.org/r180607