Bug 141975 - Implement more of the data fetching API
Summary: Implement more of the data fetching API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 142009 142014
Blocks:
  Show dependency tree / graph
 
Reported: 2015-02-24 10:22 PST by Anders Carlsson
Modified: 2015-02-25 07:03 PST (History)
4 users (show)

See Also:

Attachments
Patch (29.65 KB, patch)
2015-02-24 10:29 PST, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-02-24 10:22:49 PST 
Implement more of the data fetching API
Comment 1 Anders Carlsson 2015-02-24 10:29:43 PST 
Created attachment 247243 [details]
Patch
Comment 2 WebKit Commit Bot 2015-02-24 10:33:15 PST 
Attachment 247243 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebProcessProxy.h:125:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebProcessProxy.h:230:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebProcessProxy.cpp:653:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:113:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:116:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:153:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 6 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2015-02-24 10:35:00 PST 
Comment on attachment 247243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247243&action=review

r=me

> Source/WebCore/loader/cache/MemoryCache.h:151
> +    WEBCORE_EXPORT HashSet<RefPtr<SecurityOrigin>> originsWithCache(SessionID);

Seems like this could be const.
Comment 4 Anders Carlsson 2015-02-24 10:55:25 PST 
Committed r180575: <http://trac.webkit.org/changeset/180575>
Comment 5 Csaba Osztrogonác 2015-02-24 11:46:24 PST 
(In reply to comment #4)
> Committed r180575: <http://trac.webkit.org/changeset/180575>

new file added to cmake - http://trac.webkit.org/changeset/180577
Comment 6 Csaba Osztrogonác 2015-02-24 11:50:36 PST 
One more fix was needed because of the following warning:

../../Source/WebKit2/UIProcess/WebProcessProxy.cpp: In member function ‘virtual void WebKit::WebProcessProxy::connectionDidClose(IPC::Connection&)’:
../../Source/WebKit2/UIProcess/WebProcessProxy.cpp:152:21: error: missing initializer for member ‘WebKit::WebsiteData::entries’ [-Werror=missing-field-initializers]
         callback({ });
                     ^

fix landed in http://trac.webkit.org/changeset/180579

Let me know if you know better fix to initialize entries member of WebsiteData.