Bug 141975 – Implement more of the data fetching API

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Implement more of the data fetching API

[Anders Carlsson]

Created attachment 247243 [details]
Patch

[WebKit Commit Bot]

Attachment 247243 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebProcessProxy.h:125:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebProcessProxy.h:230:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebProcessProxy.cpp:653:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:113:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:116:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:153:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 6 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Comment on attachment 247243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247243&action=review

r=me

> Source/WebCore/loader/cache/MemoryCache.h:151
> +    WEBCORE_EXPORT HashSet<RefPtr<SecurityOrigin>> originsWithCache(SessionID);

Seems like this could be const.

[Anders Carlsson]

Committed r180575: <http://trac.webkit.org/changeset/180575>

[Csaba Osztrogonác]

(In reply to comment #4)
> Committed r180575: <http://trac.webkit.org/changeset/180575>

new file added to cmake - http://trac.webkit.org/changeset/180577

[Csaba Osztrogonác]

One more fix was needed because of the following warning:

../../Source/WebKit2/UIProcess/WebProcessProxy.cpp: In member function ‘virtual void WebKit::WebProcessProxy::connectionDidClose(IPC::Connection&)’:
../../Source/WebKit2/UIProcess/WebProcessProxy.cpp:152:21: error: missing initializer for member ‘WebKit::WebsiteData::entries’ [-Werror=missing-field-initializers]
         callback({ });
                     ^

fix landed in http://trac.webkit.org/changeset/180579

Let me know if you know better fix to initialize entries member of WebsiteData.