Bug 141965 - Hide Promise with runtime flags under Cocoa JSContext API
Summary: Hide Promise with runtime flags under Cocoa JSContext API
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
Depends on:
Reported: 2015-02-24 03:58 PST by Yusuke Suzuki
Modified: 2015-03-04 20:26 PST (History)
6 users (show)

See Also:

Patch (16.15 KB, patch)
2015-02-28 19:04 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2015-02-24 03:58:13 PST
Hide Promise with runtime flags under Cocoa JSContext API
Comment 1 Yusuke Suzuki 2015-02-24 13:52:01 PST
Spawned from https://bugs.webkit.org/show_bug.cgi?id=141859#c37
Comment 2 Yusuke Suzuki 2015-02-28 19:04:14 PST
Created attachment 247621 [details]
Comment 3 Joseph Pecoraro 2015-03-03 16:51:13 PST
Thanks for the patch! I think this makes sense for the short term.

Currently using a Promise in a JSContext application does nothing but log to syslog:

    1. Run a JSContext application
    2. Open JSContext inspector for application
    3. js> Promise.resolve("message").then(function(x) { console.log(x); })
      => Application syslog "ERROR: Event loop not supported."
      => my "then block" never fires and never logs

Ultimately we should provide some way to support promises. Until then, I think this makes sense. Someone more qualified than me should review this though.
Comment 4 Yusuke Suzuki 2015-03-04 18:34:38 PST
Could you review this patch?
Comment 5 WebKit Commit Bot 2015-03-04 20:26:13 PST
Comment on attachment 247621 [details]

Clearing flags on attachment: 247621

Committed r181064: <http://trac.webkit.org/changeset/181064>
Comment 6 WebKit Commit Bot 2015-03-04 20:26:17 PST
All reviewed patches have been landed.  Closing bug.