Bug 141962 - [GTK] Layout Test http/tests/notifications/legacy/notification-request-permission-then-navigate.html is failing
Summary: [GTK] Layout Test http/tests/notifications/legacy/notification-request-permis...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-24 01:47 PST by Marcos Chavarría Teijeiro (irc: chavaone)
Modified: 2015-03-19 06:26 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.06 KB, patch)
2015-03-19 05:11 PDT, Marcos Chavarría Teijeiro (irc: chavaone)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcos Chavarría Teijeiro (irc: chavaone) 2015-02-24 01:47:11 PST
The http/tests/notifications/legacy/notification-request-permission-then-navigate.html layout test is since r177073 (https://trac.webkit.org/changeset/r177073).

This revision implements support for HTML5 notifications.

The diff is the following:

--- /home/ch01/wk-tools/layout-test-results/http/tests/notifications/legacy/notification-request-permission-then-navigate-expected.txt
+++ /home/ch01/wk-tools/layout-test-results/http/tests/notifications/legacy/notification-request-permission-then-navigate-actual.txt
@@ -1,4 +1,5 @@
 main frame - has 1 onunload handler(s)
+CONSOLE MESSAGE: line 5: TypeError: undefined is not an object (evaluating 'window.webkitNotifications.requestPermission')
 Tests that we are not crashing when a permission request is answered after navigating

 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Comment 1 Marcos Chavarría Teijeiro (irc: chavaone) 2015-03-19 05:11:06 PDT
Created attachment 249032 [details]
Patch
Comment 2 Carlos Garcia Campos 2015-03-19 05:40:12 PDT
Comment on attachment 249032 [details]
Patch

Isn't this a gardening patch? does it need to be reviewed?
Comment 3 WebKit Commit Bot 2015-03-19 06:26:02 PDT
Comment on attachment 249032 [details]
Patch

Clearing flags on attachment: 249032

Committed r181746: <http://trac.webkit.org/changeset/181746>
Comment 4 WebKit Commit Bot 2015-03-19 06:26:06 PDT
All reviewed patches have been landed.  Closing bug.