The accessibility/roles-exposed.html layout test is failing since r179922 (https://trac.webkit.org/changeset/r179922). This revision adds a default color chooser implementation so we probably need could update the expected file but I'm not sure. The diff is the following: --- /home/ch01/wk-tools/layout-test-results/accessibility/roles-exposed-expected.txt +++ /home/ch01/wk-tools/layout-test-results/accessibility/roles-exposed-actual.txt @@ -137,7 +137,7 @@ AXRole: AXButton input[type='color'] - AXRole: AXTextField + AXRole: AXColorWell input[type='checkbox'] AXRole: AXCheckBox
<rdar://problem/19934954>
<rdar://problem/19934955>
I'll take a look at this one. But my guess is that the role should be a push button if the widget is a push button
Created attachment 247235 [details] Patch
Andrzej: Just an FYI as you seem to be actively working in this area, but for EFL (right?). The EFL test expectations already have the mapping to ATK_ROLE_COLOR_CHOOSER. But as you'll see here [1], a color chooser is a dialog (i.e. the dialog that appears when you activate the button). I wasn't sure if that mapping was deliberate/desired for your port. As a related aside, we plan to add subrole support to ATK hopefully before too long to handle cases such as this (i.e. being able to say something is a specialized type of button, namely one that results in a color chooser appearing). [1] https://developer.gnome.org/atk/unstable/AtkObject.html#AtkRole
Comment on attachment 247235 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247235&action=review > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:569 > + // ATK_ROLE_COLOR_CHOOSER is defined as a dialog (i.e. it's what appears when you push the button) Nit: Missing a period at the end of this comment.
Created attachment 247236 [details] Patch for landing
Comment on attachment 247236 [details] Patch for landing Clearing flags on attachment: 247236 Committed r180566: <http://trac.webkit.org/changeset/180566>
All reviewed patches have been landed. Closing bug.