Bug 141956 - Multiple tests are broken on Windows, because Symbol is undefined
Summary: Multiple tests are broken on Windows, because Symbol is undefined
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Regression
Depends on: 141859
Blocks:
  Show dependency tree / graph
 
Reported: 2015-02-23 23:10 PST by Alexey Proskuryakov
Modified: 2015-02-24 00:22 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-02-23 23:10:01 PST 
Tests that started to fail today:

js/dfg-to-primitive-pass-symbol.html
js/regress/constructor-with-return.html
js/symbol-abstract-equality-comparison.html
js/symbol-abstract-relational-comparison.html
js/symbol-in-map.html
js/symbol-object.html
js/symbol-prototype-is-ordinary-object.html
js/symbol-strict-equality-comparison.html
js/symbol-tostring.html
js/symbols.html

https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r180550%20(49911)/results.html
Comment 1 Brent Fulgham 2015-02-23 23:13:50 PST 
Introduced by: <https://trac.webkit.org/changeset/180547>
Comment 2 Brent Fulgham 2015-02-23 23:15:54 PST 
Two additional tests started failing in <https://trac.webkit.org/changeset/180550>.
Comment 3 Brent Fulgham 2015-02-23 23:19:46 PST 
These tests broke with r180547:
js/symbol-abstract-equality-comparison.html
js/symbol-abstract-relational-comparison.html
js/symbol-in-map.html
js/symbol-object.html
js/symbol-prototype-is-ordinary-object.html
js/symbol-strict-equality-comparison.html
js/symbol-tostring.html
js/symbols.html

These broke with r180550:
js/dfg-to-primitive-pass-symbol.html
js/regress/constructor-with-return.html
]
Comment 4 Brent Fulgham 2015-02-23 23:24:31 PST 
Rolled out offending change in https://bugs.webkit.org/show_bug.cgi?id=141957.
Comment 5 Brent Fulgham 2015-02-23 23:29:16 PST 
Rolled out in <https://trac.webkit.org/changeset/180551>.
Comment 6 Alexey Proskuryakov 2015-02-24 00:22:52 PST 
So, marking as fixed. Thanks!