Bug 141941 - [Cocoa] Break internal reference cycle in WebCore::Font.
Summary: [Cocoa] Break internal reference cycle in WebCore::Font.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-23 17:37 PST by Andreas Kling
Modified: 2015-02-24 08:46 PST (History)
4 users (show)

See Also:


Attachments
Patch (5.43 KB, patch)
2015-02-23 17:39 PST, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch (5.42 KB, patch)
2015-02-23 17:41 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-02-23 17:37:25 PST
The Cocoa version of Font::platformCreateScaledFont() has a bug where it will return "this" for a 0pt font.
This causes a reference cycle when creating a small-caps variant for a 0pt font.
Comment 1 Andreas Kling 2015-02-23 17:39:19 PST
<rdar://problem/19650570>
Comment 2 Andreas Kling 2015-02-23 17:39:46 PST
Created attachment 247176 [details]
Patch
Comment 3 Andreas Kling 2015-02-23 17:41:22 PST
Created attachment 247178 [details]
Patch
Comment 4 Myles C. Maxfield 2015-02-23 17:43:33 PST
Comment on attachment 247178 [details]
Patch

How can we test this?
Comment 5 Andreas Kling 2015-02-23 17:45:55 PST
(In reply to comment #4)
> Comment on attachment 247178 [details]
> Patch
> 
> How can we test this?

I have no idea how to test this in any reliable way.
Comment 6 WebKit Commit Bot 2015-02-24 08:46:35 PST
Comment on attachment 247178 [details]
Patch

Clearing flags on attachment: 247178

Committed r180561: <http://trac.webkit.org/changeset/180561>
Comment 7 WebKit Commit Bot 2015-02-24 08:46:39 PST
All reviewed patches have been landed.  Closing bug.