Patch forthcoming.
Ossy: this will have some new callOperation() overloads in JIT.h. Expect breakage.
(In reply to comment #1) > Ossy: this will have some new callOperation() overloads in JIT.h. Expect > breakage. Actually, we might get lucky. The new overloads seem to bottom out in existing setupArgumentsXYZ overloads.
Created attachment 247131 [details] the patch
Attachment 247131 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name "symbolTable" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 247131 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=247131&action=review r=me > Source/JavaScriptCore/jit/JITOperations.cpp:71 > + // FIXME: This won't work if this operation is called from the DFG or FTL. > + // This should be changed to pass in the new scope. I see that this came from pre-existing code, but can you add a debug ASSERT to ensure that the current exec/frame is not a DFG/FTL frame so that we'll catch this if someone unwittingly uses this in the DFG/FTL without seeing this FIXME? > Source/JavaScriptCore/runtime/JSSymbolTableObject.h:64 > + nit: unneeded white space.
(In reply to comment #5) > Comment on attachment 247131 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=247131&action=review > > r=me > > > Source/JavaScriptCore/jit/JITOperations.cpp:71 > > + // FIXME: This won't work if this operation is called from the DFG or FTL. > > + // This should be changed to pass in the new scope. > > I see that this came from pre-existing code, but can you add a debug ASSERT > to ensure that the current exec/frame is not a DFG/FTL frame so that we'll > catch this if someone unwittingly uses this in the DFG/FTL without seeing > this FIXME? Sure. > > > Source/JavaScriptCore/runtime/JSSymbolTableObject.h:64 > > + > > nit: unneeded white space. OK.
Created attachment 247134 [details] patch for landing
Created attachment 247137 [details] fix 32-bit
Landed in http://trac.webkit.org/changeset/180514
(In reply to comment #1) > Ossy: this will have some new callOperation() overloads in JIT.h. Expect > breakage. Thanks for the notice, fix landed in http://trac.webkit.org/changeset/180515