Bug 141910 - Occasional crash in MediaPlayer::setPrivateBrowsingMode
Summary: Occasional crash in MediaPlayer::setPrivateBrowsingMode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-02-23 09:16 PST by Eric Carlson
Modified: 2016-03-21 08:55 PDT (History)
0 users

See Also:

Attachments
Proposed patch (1.66 KB, patch)
2015-02-23 09:19 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2015-02-23 09:16:08 PST 
The iOS bots occasionally crash in MediaPlayer::setPrivateBrowsingMode:

WebCore::MediaPlayer::setPrivateBrowsingMode(bool) + 4
WebCore::HTMLMediaElement::loadResource(WebCore::URL const&, WebCore::ContentType&, WTF::String const&) + 1160
WebCore::HTMLMediaElement::selectMediaResource() + 802
WebCore::HTMLMediaElement::loadTimerFired() + 77
Comment 1 Eric Carlson 2015-02-23 09:19:22 PST 
Created attachment 247123 [details]
Proposed patch
Comment 2 Jer Noble 2015-02-23 11:13:16 PST 
Comment on attachment 247123 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247123&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:4743
> +    clearMediaPlayer(-1);

😱

Could we add an entry to DelayedActionType called "AllActions" or something?
Comment 3 Eric Carlson 2015-02-23 11:28:36 PST 
Committed r180510: https://trac.webkit.org/r180510