Bug 141898 – Web Inspector: Do not show "{}" after Date description in Object Previews

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
In testing, I see "{}" empty property lists after date instance preview strings. That is misleading and poor. We should just not show it.

* STEPS TO REPRODUCE
1. js> ({a: new Date})
 => expand object

* NOTES
- Requires getProperties to send back object previews, and rendering those previews

[Joseph Pecoraro]

Created attachment 247105 [details]
[PATCH] Proposed Fix

[Timothy Hatcher]

Comment on attachment 247105 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=247105&action=review

> Source/WebInspectorUI/ChangeLog:11
> +        Only show "{...}" section for Date objects that have user
> +        defined properties. Otherwise, Dates do not have properties.

We should consider this for RegExp too.

[Joseph Pecoraro]

(In reply to comment #2)
> Comment on attachment 247105 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=247105&action=review
> 
> > Source/WebInspectorUI/ChangeLog:11
> > +        Only show "{...}" section for Date objects that have user
> > +        defined properties. Otherwise, Dates do not have properties.
> 
> We should consider this for RegExp too.

Yep, you pointed out RegExp and Error types. Those are slightly unique in that they have some base set of properties. I'll address them separately.

RegExps for instance I'm wondering if there is value in having them still be expandable, or showing preview data if "lastIndex" is non-zero. The rare cases that is being used it would be useful to see that at a glance.

Errors should just be expandable, and improve their "stack" output handling.

[Joseph Pecoraro]

http://trac.webkit.org/changeset/180592