RESOLVED FIXED 141889
Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length 
https://bugs.webkit.org/show_bug.cgi?id=141889
Summary Bot watcher's dashboard sometimes hits an assertion: data.num_missing === thi...
Alexey Proskuryakov
Reported 2015-02-22 22:30:01 PST
data.num_missing count includes tests that only had missing pixel results on retry (e.g. "TEXT MISSING"). The overall outcome for such tests is of course REGRESSION, and not MISSING, so we don't include them in layoutTestResults.testsWithMissingResults, and probably shouldn't.
Attachments
proposed fix (1.83 KB, patch)
2015-02-22 22:31 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-02-22 22:31:28 PST
Created attachment 247099 [details] proposed fix
WebKit Commit Bot
Comment 2 2015-02-24 20:33:07 PST
Comment on attachment 247099 [details] proposed fix Clearing flags on attachment: 247099 Committed r180611: <http://trac.webkit.org/changeset/180611>
WebKit Commit Bot
Comment 3 2015-02-24 20:33:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.