Bug 141889 - Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
Summary: Bot watcher's dashboard sometimes hits an assertion: data.num_missing === thi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-22 22:30 PST by Alexey Proskuryakov
Modified: 2015-02-24 20:33 PST (History)
3 users (show)

See Also:

Attachments
proposed fix (1.83 KB, patch)
2015-02-22 22:31 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-02-22 22:30:01 PST 
data.num_missing count includes tests that only had missing pixel results on retry (e.g. "TEXT MISSING"). The overall outcome for such tests is of course REGRESSION, and not MISSING, so we don't include them in layoutTestResults.testsWithMissingResults, and probably shouldn't.
Comment 1 Alexey Proskuryakov 2015-02-22 22:31:28 PST 
Created attachment 247099 [details]
proposed fix
Comment 2 WebKit Commit Bot 2015-02-24 20:33:07 PST 
Comment on attachment 247099 [details]
proposed fix

Clearing flags on attachment: 247099

Committed r180611: <http://trac.webkit.org/changeset/180611>
Comment 3 WebKit Commit Bot 2015-02-24 20:33:10 PST 
All reviewed patches have been landed.  Closing bug.