Bug 141886 - [iOS] Max canvas size is lower than expected
Summary: [iOS] Max canvas size is lower than expected
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-22 18:38 PST by Dean Jackson
Modified: 2015-02-23 14:42 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.12 KB, patch)
2015-02-22 18:42 PST, Dean Jackson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2015-02-22 18:38:31 PST
[iOS] Max canvas size is lower than expected
Comment 1 Dean Jackson 2015-02-22 18:42:30 PST
Created attachment 247091 [details]
Patch
Comment 2 Antoine Quint 2015-02-22 23:32:29 PST
While I greatly appreciate this limit being bumped to a more accurate limit, what exactly is the purpose of the limit? Is it for performance reason? Memory consumption reasons? If so, why not let content degrade and/or jetsam if values are too large? Especially as there is no mechanism in place to predictably figure out, in code, whether a given <canvas> size will actually allow the content to be rendered.
Comment 3 Dean Jackson 2015-02-23 10:20:23 PST
(In reply to comment #2)
> While I greatly appreciate this limit being bumped to a more accurate limit,
> what exactly is the purpose of the limit? Is it for performance reason?
> Memory consumption reasons? If so, why not let content degrade and/or jetsam
> if values are too large? Especially as there is no mechanism in place to
> predictably figure out, in code, whether a given <canvas> size will actually
> allow the content to be rendered.

I tried Firefox and it fails silently when the canvas gets too big, like us. So I think it is worth keeping a limit in, just in case.

Note that it's a pretty bad developer experience if their page instantly quits/crashes - that gives them no way to debug without removing random code and starting over. At least with a large limit they'll get a warning in the console as to what went wrong.
Comment 4 Dean Jackson 2015-02-23 14:42:48 PST
Committed r180520: <http://trac.webkit.org/changeset/180520>