Bug 141876 - Web Inspector: Make Console UI icons / lines slightly larger
Summary: Web Inspector: Make Console UI icons / lines slightly larger
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-02-21 18:35 PST by Joseph Pecoraro
Modified: 2015-02-22 08:43 PST (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (4.07 KB, patch)
2015-02-21 18:41 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (4.07 KB, patch)
2015-02-21 19:04 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-02-21 18:35:40 PST 
* SUMMARY
Make Console UI icons / lines slightly larger.

This is in preparation for a new ObjectTree design that contains 16x16 icons. So bump up the size of the existing Console icons / lines which are currently much smaller (10x10). This brings them up to 12x12.
Comment 1 Joseph Pecoraro 2015-02-21 18:41:29 PST 
Created attachment 247073 [details]
[PATCH] Proposed Fix

Overall I think this is shippable.

I was seeing an issue where certain error lines were 22px tall instead of 21. I was unable to track down that particular issue. Lets address it separately though.
Comment 2 WebKit Commit Bot 2015-02-21 18:43:07 PST 
Attachment 247073 [details] did not pass style-queue:


ERROR: Source/WebInspectorUI/UserInterface/Views/LogContentView.css:445:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Joseph Pecoraro 2015-02-21 19:04:55 PST 
Created attachment 247075 [details]
[PATCH] Proposed Fix

Fixed style issue.
Comment 4 WebKit Commit Bot 2015-02-22 08:43:48 PST 
Comment on attachment 247075 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 247075

Committed r180484: <http://trac.webkit.org/changeset/180484>
Comment 5 WebKit Commit Bot 2015-02-22 08:43:52 PST 
All reviewed patches have been landed.  Closing bug.