Bug 141875 - Web Inspector: Generate Previews more often for RemoteObject interaction
Summary: Web Inspector: Generate Previews more often for RemoteObject interaction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-02-21 18:25 PST by Joseph Pecoraro
Modified: 2015-02-21 19:50 PST (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (18.63 KB, patch)
2015-02-21 18:30 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (18.63 KB, patch)
2015-02-21 18:31 PST, Joseph Pecoraro
timothy: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
[PATCH] For Landing (18.64 KB, patch)
2015-02-21 19:00 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-02-21 18:25:24 PST
* SUMMARY
Generate Previews more often for RemoteObject interaction.

Enable, fix, and use "generatePreview" in more places.
Comment 1 Radar WebKit Bug Importer 2015-02-21 18:25:39 PST
<rdar://problem/19915261>
Comment 2 Joseph Pecoraro 2015-02-21 18:30:52 PST
Created attachment 247071 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2015-02-21 18:31:28 PST
Created attachment 247072 [details]
[PATCH] Proposed Fix
Comment 4 Timothy Hatcher 2015-02-21 18:43:32 PST
Comment on attachment 247072 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=247072&action=review

> Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js:394
> +        RuntimeAgent.callFunctionOn(this._objectId, functionDeclaration.toString(), args, true, undefined, true mycallback);

Missing a comma.
Comment 5 Joseph Pecoraro 2015-02-21 18:56:11 PST
Comment on attachment 247072 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=247072&action=review

>> Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js:394
>> +        RuntimeAgent.callFunctionOn(this._objectId, functionDeclaration.toString(), args, true, undefined, true mycallback);
> 
> Missing a comma.

Arg, good catch!! This was me rebasing to get isolated patches and this was the only conflict. Fail!
Comment 6 Joseph Pecoraro 2015-02-21 19:00:46 PST
Created attachment 247074 [details]
[PATCH] For Landing
Comment 7 WebKit Commit Bot 2015-02-21 19:50:49 PST
Comment on attachment 247074 [details]
[PATCH] For Landing

Clearing flags on attachment: 247074

Committed r180483: <http://trac.webkit.org/changeset/180483>
Comment 8 WebKit Commit Bot 2015-02-21 19:50:53 PST
All reviewed patches have been landed.  Closing bug.