Bug 141861 – Print a console warning when HTMLCanvasElement exceeds the maximum size

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dean Jackson]

Print a console warning when HTMLCanvasElement exceeds the maximum size

[Dean Jackson]

Created attachment 247014 [details]
Patch

[Dean Jackson]

        <rdar://problem/19729145>

[Simon Fraser (smfr)]

Comment on attachment 247014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247014&action=review

> Source/WebCore/html/HTMLCanvasElement.cpp:558
> +        document().addConsoleMessage(MessageSource::JS, MessageLevel::Warning, ASCIILiteral("Canvas size exceeds the maximum limit. Draw operations will not produce output."));

I think this should say what the limit is.

[Dean Jackson]

Created attachment 247017 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 247017 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247017&action=review

> Source/WebCore/html/HTMLCanvasElement.cpp:559
> +        stringBuilder.append("Canvas size exceeds the maximum limit (width * height > ");

Maybe "canvas area exceeds"

> LayoutTests/fast/canvas/huge-canvas-error-expected.txt:1
> +CONSOLE MESSAGE: line 14: Canvas size exceeds the maximum limit. Draw operations will not produce output.

You'll have to fix this.

[Dean Jackson]

Created attachment 247020 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 247020 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247020&action=review

> Source/WebCore/html/HTMLCanvasElement.cpp:559
> +        stringBuilder.append("Canvas size exceeds the maximum limit (width * height > ");

Canvas area ("size" is ambiguous).

> Source/WebCore/html/HTMLCanvasElement.cpp:561
> +        stringBuilder.append("). Draw operations will not produce output.");

Does "Draw operations will not produce output" add anything? Maybe drop it.

[Build Bot]

Comment on attachment 247020 [details]
Patch

Attachment 247020 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4509105733500928

New failing tests:
fast/canvas/pattern-too-large-to-create.html
fast/canvas/canvas-toDataURL-crash.html

[Build Bot]

Created attachment 247026 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 247020 [details]
Patch

Attachment 247020 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4909735987904512

New failing tests:
fast/canvas/pattern-too-large-to-create.html
fast/canvas/canvas-toDataURL-crash.html

[Build Bot]

Created attachment 247030 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Dean Jackson]

Committed r180492: <http://trac.webkit.org/changeset/180492>