RESOLVED FIXED141855
Scrollbars and ScrollAnimators must always have a ScrollableArea 
https://bugs.webkit.org/show_bug.cgi?id=141855
Summary Scrollbars and ScrollAnimators must always have a ScrollableArea
Brent Fulgham
Reported 2015-02-20 14:21:58 PST
It doesn't make sense for a ScrollAnimator to exist without a ScrollableArea. So rather than holding a pointer to the ScrollableArea it is responsible for, have it use a reference.
Attachments
Patch (75.14 KB, patch)
2015-02-20 16:36 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (77.85 KB, patch)
2015-02-20 16:57 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch v3 (Fixes for Windows and other ports) (79.02 KB, patch)
2015-02-20 17:28 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch v4 (iOS fixes) (80.09 KB, patch)
2015-02-20 17:35 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch v5 (Efl fix) (81.32 KB, patch)
2015-02-20 17:37 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (81.97 KB, patch)
2015-02-20 17:50 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch v7 (Gtk fix) (83.09 KB, patch)
2015-02-20 18:05 PST, Brent Fulgham 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2015-02-20 14:38:47 PST
Likewise, a Scrollbar should always be associated with a ScrollArea.
Brent Fulgham
Comment 2 2015-02-20 16:36:46 PST
Created attachment 247011 [details] Patch
Brent Fulgham
Comment 3 2015-02-20 16:57:16 PST
Created attachment 247013 [details] Patch
Brent Fulgham
Comment 4 2015-02-20 17:28:49 PST
Created attachment 247018 [details] Patch v3 (Fixes for Windows and other ports)
Brent Fulgham
Comment 5 2015-02-20 17:35:37 PST
Created attachment 247019 [details] Patch v4 (iOS fixes)
Brent Fulgham
Comment 6 2015-02-20 17:37:57 PST
Created attachment 247021 [details] Patch v5 (Efl fix)
Radar WebKit Bug Importer
Comment 7 2015-02-20 17:39:15 PST
<rdar://problem/19912140>
Brent Fulgham
Comment 8 2015-02-20 17:50:08 PST
Created attachment 247023 [details] Patch
Brent Fulgham
Comment 9 2015-02-20 18:05:20 PST
Created attachment 247028 [details] Patch v7 (Gtk fix)
Brent Fulgham
Comment 10 2015-02-20 19:34:20 PST
Committed r180474: <http://trac.webkit.org/changeset/180474>
Brent Fulgham
Comment 11 2015-02-20 19:36:04 PST
I think I fixed the Gtk build when I landed, but I will watch the bots to make sure.
Brent Fulgham
Comment 12 2015-02-20 19:45:26 PST
(In reply to comment #11) > I think I fixed the Gtk build when I landed, but I will watch the bots to > make sure. Bah! Of course I failed. Gtk build fix in r180475. <http://trac.webkit.org/changeset/180475>
Note You need to log in before you can comment on or make changes to this bug.