Bug 141855 - Scrollbars and ScrollAnimators must always have a ScrollableArea
Summary: Scrollbars and ScrollAnimators must always have a ScrollableArea
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks: 140633
  Show dependency tree / graph
 
Reported: 2015-02-20 14:21 PST by Brent Fulgham
Modified: 2015-02-20 19:45 PST (History)
5 users (show)

See Also:

Attachments
Patch (75.14 KB, patch)
2015-02-20 16:36 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (77.85 KB, patch)
2015-02-20 16:57 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch v3 (Fixes for Windows and other ports) (79.02 KB, patch)
2015-02-20 17:28 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch v4 (iOS fixes) (80.09 KB, patch)
2015-02-20 17:35 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch v5 (Efl fix) (81.32 KB, patch)
2015-02-20 17:37 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (81.97 KB, patch)
2015-02-20 17:50 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch v7 (Gtk fix) (83.09 KB, patch)
2015-02-20 18:05 PST, Brent Fulgham 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-02-20 14:21:58 PST 
It doesn't make sense for a ScrollAnimator to exist without a ScrollableArea. So rather than holding a pointer to the ScrollableArea it is responsible for, have it use a reference.
Comment 1 Brent Fulgham 2015-02-20 14:38:47 PST 
Likewise, a Scrollbar should always be associated with a ScrollArea.
Comment 2 Brent Fulgham 2015-02-20 16:36:46 PST 
Created attachment 247011 [details]
Patch
Comment 3 Brent Fulgham 2015-02-20 16:57:16 PST 
Created attachment 247013 [details]
Patch
Comment 4 Brent Fulgham 2015-02-20 17:28:49 PST 
Created attachment 247018 [details]
Patch v3 (Fixes for Windows and other ports)
Comment 5 Brent Fulgham 2015-02-20 17:35:37 PST 
Created attachment 247019 [details]
Patch v4 (iOS fixes)
Comment 6 Brent Fulgham 2015-02-20 17:37:57 PST 
Created attachment 247021 [details]
Patch v5 (Efl fix)
Comment 7 Radar WebKit Bug Importer 2015-02-20 17:39:15 PST 
<rdar://problem/19912140>
Comment 8 Brent Fulgham 2015-02-20 17:50:08 PST 
Created attachment 247023 [details]
Patch
Comment 9 Brent Fulgham 2015-02-20 18:05:20 PST 
Created attachment 247028 [details]
Patch v7 (Gtk fix)
Comment 10 Brent Fulgham 2015-02-20 19:34:20 PST 
Committed r180474: <http://trac.webkit.org/changeset/180474>
Comment 11 Brent Fulgham 2015-02-20 19:36:04 PST 
I think I fixed the Gtk build when I landed, but I will watch the bots to make sure.
Comment 12 Brent Fulgham 2015-02-20 19:45:26 PST 
(In reply to comment #11)
> I think I fixed the Gtk build when I landed, but I will watch the bots to
> make sure.

Bah! Of course I failed.

Gtk build fix in r180475. <http://trac.webkit.org/changeset/180475>