RESOLVED FIXED 141851
Get rid of JSNameScope::m_type 
https://bugs.webkit.org/show_bug.cgi?id=141851
Summary Get rid of JSNameScope::m_type
Filip Pizlo
Reported 2015-02-20 12:47:09 PST
The type can be described using different JSNameScope subclasses. Then the flag is essentially conveyed using ClassInfo.
Attachments
the patch (34.43 KB, patch)
2015-02-20 14:17 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (37.20 KB, patch)
2015-02-20 14:33 PST, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-02-20 14:17:10 PST
Created attachment 247001 [details] the patch
WebKit Commit Bot
Comment 2 2015-02-20 14:19:57 PST
Attachment 247001 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name "vm" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name "globalObject" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name "identifier" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 5 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2015-02-20 14:20:46 PST
(In reply to comment #2) > Attachment 247001 [details] did not pass style-queue: > > > ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name > "vm" adds no information, so it should be removed. > [readability/parameter_name] [5] > ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name > "globalObject" adds no information, so it should be removed. > [readability/parameter_name] [5] > ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name > "identifier" adds no information, so it should be removed. > [readability/parameter_name] [5] > ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name > "value" adds no information, so it should be removed. > [readability/parameter_name] [5] > ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name > "type" adds no information, so it should be removed. > [readability/parameter_name] [5] > Total errors found: 5 in 17 files Fixed locally. > > > If any of these errors are false positives, please file a bug against > check-webkit-style.
Filip Pizlo
Comment 4 2015-02-20 14:33:18 PST
Created attachment 247005 [details] the patch Fixes.
Geoffrey Garen
Comment 5 2015-02-20 14:34:42 PST
Comment on attachment 247005 [details] the patch r=me
Filip Pizlo
Comment 6 2015-02-20 14:55:22 PST
Landed in http://trac.webkit.org/changeset/180460
Filip Pizlo
Comment 7 2015-02-20 14:57:31 PST
gcc build fix in http://trac.webkit.org/changeset/180461
Note You need to log in before you can comment on or make changes to this bug.