The type can be described using different JSNameScope subclasses. Then the flag is essentially conveyed using ClassInfo.
Created attachment 247001 [details] the patch
Attachment 247001 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name "vm" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name "globalObject" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name "identifier" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 5 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 247001 [details] did not pass style-queue: > > > ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name > "vm" adds no information, so it should be removed. > [readability/parameter_name] [5] > ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name > "globalObject" adds no information, so it should be removed. > [readability/parameter_name] [5] > ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name > "identifier" adds no information, so it should be removed. > [readability/parameter_name] [5] > ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name > "value" adds no information, so it should be removed. > [readability/parameter_name] [5] > ERROR: Source/JavaScriptCore/runtime/JSNameScope.h:52: The parameter name > "type" adds no information, so it should be removed. > [readability/parameter_name] [5] > Total errors found: 5 in 17 files Fixed locally. > > > If any of these errors are false positives, please file a bug against > check-webkit-style.
Created attachment 247005 [details] the patch Fixes.
Comment on attachment 247005 [details] the patch r=me
Landed in http://trac.webkit.org/changeset/180460
gcc build fix in http://trac.webkit.org/changeset/180461