Bug 141836 - [WK2][EFL] Fix the build after r180362
Summary: [WK2][EFL] Fix the build after r180362
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on: 141813
Blocks: 141808
  Show dependency tree / graph
 
Reported: 2015-02-20 03:23 PST by Gyuyoung Kim
Modified: 2015-02-20 12:12 PST (History)
4 users (show)

See Also:

Attachments
WIP (5.10 KB, patch)
2015-02-20 03:34 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
WIP (4.04 KB, patch)
2015-02-20 03:50 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (5.57 KB, patch)
2015-02-20 05:00 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (5.59 KB, patch)
2015-02-20 05:23 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-02-20 03:23:30 PST 
r180409 fixed GTK port though, EFL port is still broken.
Comment 1 Gyuyoung Kim 2015-02-20 03:34:53 PST 
Created attachment 246959 [details]
WIP
Comment 2 Gyuyoung Kim 2015-02-20 03:50:28 PST 
Created attachment 246960 [details]
WIP
Comment 3 Gyuyoung Kim 2015-02-20 05:00:24 PST 
Created attachment 246963 [details]
Patch
Comment 4 Carlos Garcia Campos 2015-02-20 05:03:04 PST 
Comment on attachment 246963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246963&action=review

> Source/WebKit2/UIProcess/API/C/efl/WKAPICastEfl.h:115
> +inline WKPopupMenuListenerRef toAPI(WebPopupMenuListenerEfl* popup)
> +{
> +    return static_cast<WKPopupMenuListenerRef>(static_cast<void*>(popup));
> +}
> +
> +inline WebPopupMenuListenerEfl* toImpl(WKPopupMenuListenerRef popupRef)
> +{
> +    return static_cast<WebPopupMenuListenerEfl*>(static_cast<void*>(const_cast<OpaqueWKPopupMenuListener*>(popupRef)));
> +}

I wonder why you need this, isn't WebPopupMenuListenerEfl an API::Object?
Comment 5 Gyuyoung Kim 2015-02-20 05:08:11 PST 
Comment on attachment 246963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246963&action=review

>> Source/WebKit2/UIProcess/API/C/efl/WKAPICastEfl.h:115
>> +}
> 
> I wonder why you need this, isn't WebPopupMenuListenerEfl an API::Object?

Yes, it is not API::Object yet.

http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/efl/WebPopupMenuListenerEfl.h#L33
Comment 6 Carlos Garcia Campos 2015-02-20 05:11:18 PST 
(In reply to comment #5)
> Comment on attachment 246963 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=246963&action=review
> 
> >> Source/WebKit2/UIProcess/API/C/efl/WKAPICastEfl.h:115
> >> +}
> > 
> > I wonder why you need this, isn't WebPopupMenuListenerEfl an API::Object?
> 
> Yes, it is not API::Object yet.
> 
> http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/efl/
> WebPopupMenuListenerEfl.h#L33

Ok, then I guess you should add template specialization, like Zan suggested in the GTK+ patch
Comment 7 Gyuyoung Kim 2015-02-20 05:23:18 PST 
Created attachment 246966 [details]
Patch
Comment 8 Gyuyoung Kim 2015-02-20 06:29:05 PST 
Comment on attachment 246966 [details]
Patch

Clearing flags on attachment: 246966

Committed r180411: <http://trac.webkit.org/changeset/180411>
Comment 9 Gyuyoung Kim 2015-02-20 06:29:12 PST 
All reviewed patches have been landed.  Closing bug.