r180409 fixed GTK port though, EFL port is still broken.
Created attachment 246959 [details] WIP
Created attachment 246960 [details] WIP
Created attachment 246963 [details] Patch
Comment on attachment 246963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246963&action=review > Source/WebKit2/UIProcess/API/C/efl/WKAPICastEfl.h:115 > +inline WKPopupMenuListenerRef toAPI(WebPopupMenuListenerEfl* popup) > +{ > + return static_cast<WKPopupMenuListenerRef>(static_cast<void*>(popup)); > +} > + > +inline WebPopupMenuListenerEfl* toImpl(WKPopupMenuListenerRef popupRef) > +{ > + return static_cast<WebPopupMenuListenerEfl*>(static_cast<void*>(const_cast<OpaqueWKPopupMenuListener*>(popupRef))); > +} I wonder why you need this, isn't WebPopupMenuListenerEfl an API::Object?
Comment on attachment 246963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246963&action=review >> Source/WebKit2/UIProcess/API/C/efl/WKAPICastEfl.h:115 >> +} > > I wonder why you need this, isn't WebPopupMenuListenerEfl an API::Object? Yes, it is not API::Object yet. http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/efl/WebPopupMenuListenerEfl.h#L33
(In reply to comment #5) > Comment on attachment 246963 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=246963&action=review > > >> Source/WebKit2/UIProcess/API/C/efl/WKAPICastEfl.h:115 > >> +} > > > > I wonder why you need this, isn't WebPopupMenuListenerEfl an API::Object? > > Yes, it is not API::Object yet. > > http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/efl/ > WebPopupMenuListenerEfl.h#L33 Ok, then I guess you should add template specialization, like Zan suggested in the GTK+ patch
Created attachment 246966 [details] Patch
Comment on attachment 246966 [details] Patch Clearing flags on attachment: 246966 Committed r180411: <http://trac.webkit.org/changeset/180411>
All reviewed patches have been landed. Closing bug.