Bug 141835 – [GTK] Layout Test media/video-controls-no-scripting.html is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Marcos Chavarría Teijeiro (irc: chavaone)]

The media/video-controls-no-scripting.html layout test is failing after rr178648.

Probably we need to rebaseline the test here.

Missing line number:

--- /home/ch01/wk-tools/layout-test-results/media/video-controls-no-scripting-expected.txt
+++ /home/ch01/wk-tools/layout-test-results/media/video-controls-no-scripting-actual.txt
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 10: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.
+CONSOLE MESSAGE: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.
 CONSOLE MESSAGE: line 13: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.

 Tests that the built-in controls are always enabled when JavaScript is disabled.

[Alexey Proskuryakov]

It's probably fine to update the results for now, however this may be a sign of a bug in console that line number generation is flaky on this test.

[Marcos Chavarría Teijeiro (irc: chavaone)]

The test is failing again after r184329 ().

The new diff is the following:

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/media/video-controls-no-scripting-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/media/video-controls-no-scripting-actual.txt
@@ -1,5 +1,6 @@
 CONSOLE MESSAGE: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.
 CONSOLE MESSAGE: line 13: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.
+CONSOLE MESSAGE: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.
 
 Tests that the built-in controls are always enabled when JavaScript is disabled.

[Carlos Alberto Lopez Perez]

This test is now timing out because of bug 152797

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 318488 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 318488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318488&action=review

> LayoutTests/ChangeLog:8
> +        The output appears to be consistent based on local testing.

You can see its still failing on the bot: media/video-controls-no-scripting-diff.txt

$ curl -s https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/2689/steps/layout-test/logs/stdio/text|grep media/video-controls-no-scripting
03:22:36.244 11162 "ruby -I /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Websites/bugs.webkit.org/PrettyPatch /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Websites/bugs.webkit.org/PrettyPatch/prettify.rb /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/media/video-controls-no-scripting-diff.txt" took 0.16s
03:22:36.245 11162 worker/9 media/video-controls-no-scripting.html failed:

And you can find the diff here: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r220912%20(2689)/media/video-controls-no-scripting-pretty-diff.html

[Carlos Alberto Lopez Perez]

Comment on attachment 318488 [details]
Patch

Ok... missed the rebaseline. Sorry
/me goes for more coffee

[WebKit Commit Bot]

Comment on attachment 318488 [details]
Patch

Clearing flags on attachment: 318488

Committed r220915: <http://trac.webkit.org/changeset/220915>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33961964>