Bug 141829 - [WebEditingTester] Implement an open panel
Summary: [WebEditingTester] Implement an open panel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-20 02:03 PST by Tim Horton
Modified: 2015-02-20 12:00 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.46 KB, patch)
2015-02-20 02:03 PST, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-02-20 02:03:25 PST 
[WebEditingTester] Implement an open panel
Comment 1 Tim Horton 2015-02-20 02:03:38 PST 
Created attachment 246950 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-02-20 11:41:09 PST 
Comment on attachment 246950 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246950&action=review

> Tools/WebEditingTester/AppDelegate.m:145
> +- (void)_useWebKit1ForOpeningDocument:(id)sender

sounds like a BOOL. Maybe openDocumentWithWebKit1.

> Tools/WebEditingTester/AppDelegate.m:150
> +- (void)_useWebKit2ForOpeningDocument:(id)sender

Ditto

> Tools/WebEditingTester/AppDelegate.m:160
> +    [radioButtonPrototype setButtonType:NSRadioButton];

DOT

> Tools/WebEditingTester/AppDelegate.m:182
> +        [[controller window] makeKeyAndOrderFront:nil];

DOT
Comment 3 Tim Horton 2015-02-20 12:00:08 PST 
http://trac.webkit.org/changeset/180438