Bug 141828 - [WebEditingTester] Hook up key equivalents for new window action
Summary: [WebEditingTester] Hook up key equivalents for new window action
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-20 02:02 PST by Tim Horton
Modified: 2015-02-20 11:18 PST (History)
5 users (show)

See Also:


Attachments
Patch (13.32 KB, patch)
2015-02-20 02:03 PST, Tim Horton
enrica: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-02-20 02:02:48 PST
[WebEditingTester] Hook up key equivalents for new window action
Comment 1 Tim Horton 2015-02-20 02:03:00 PST
Created attachment 246949 [details]
Patch
Comment 2 WebKit Commit Bot 2015-02-20 02:05:54 PST
Attachment 246949 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Enrica Casucci 2015-02-20 11:15:51 PST
Comment on attachment 246949 [details]
Patch

Looks good to me. Add the bug url to the ChangeLog.
Comment 4 Tim Horton 2015-02-20 11:18:37 PST
http://trac.webkit.org/changeset/180429