RESOLVED FIXED 141826
[WebEditingTester] Factor out list of editing operations 
https://bugs.webkit.org/show_bug.cgi?id=141826
Summary [WebEditingTester] Factor out list of editing operations
Tim Horton
Reported 2015-02-20 02:01:24 PST
[WebEditingTester] Factor out list of editing operations
Attachments
Patch (17.22 KB, patch)
2015-02-20 02:01 PST, Tim Horton 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-02-20 02:01:46 PST
Created attachment 246947 [details] Patch
WebKit Commit Bot
Comment 2 2015-02-20 02:04:14 PST
Attachment 246947 [details] did not pass style-queue: ERROR: Tools/WebEditingTester/EditingOperations.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2015-02-20 10:05:26 PST
Comment on attachment 246947 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246947&action=review > Tools/WebEditingTester/EditingOperations.m:35 > + static NSArray *operationNames; > + static dispatch_once_t onceToken; > + dispatch_once(&onceToken, ^{ > + operationNames = @[ I don't think you need the dispatch_once here. I think you can just return the array literal.
Tim Horton
Comment 4 2015-02-20 11:14:14 PST
http://trac.webkit.org/changeset/180425
Note You need to log in before you can comment on or make changes to this bug.