Bug 141826 - [WebEditingTester] Factor out list of editing operations
Summary: [WebEditingTester] Factor out list of editing operations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-20 02:01 PST by Tim Horton
Modified: 2015-02-20 11:14 PST (History)
5 users (show)

See Also:

Attachments
Patch (17.22 KB, patch)
2015-02-20 02:01 PST, Tim Horton 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-02-20 02:01:24 PST 
[WebEditingTester] Factor out list of editing operations
Comment 1 Tim Horton 2015-02-20 02:01:46 PST 
Created attachment 246947 [details]
Patch
Comment 2 WebKit Commit Bot 2015-02-20 02:04:14 PST 
Attachment 246947 [details] did not pass style-queue:


ERROR: Tools/WebEditingTester/EditingOperations.m:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2015-02-20 10:05:26 PST 
Comment on attachment 246947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246947&action=review

> Tools/WebEditingTester/EditingOperations.m:35
> +    static NSArray *operationNames;
> +    static dispatch_once_t onceToken;
> +    dispatch_once(&onceToken, ^{
> +        operationNames = @[

I don't think you need the dispatch_once here.  I think you can just return the array literal.
Comment 4 Tim Horton 2015-02-20 11:14:14 PST 
http://trac.webkit.org/changeset/180425