Bug 141765 - [Win] CFData leak in CDMSessionAVFoundationCF
Summary: [Win] CFData leak in CDMSessionAVFoundationCF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-02-18 12:44 PST by Joseph Pecoraro
Modified: 2015-02-18 16:20 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.75 KB, patch)
2015-02-18 14:36 PST, Brent Fulgham 		joepeck: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-02-18 12:44:33 PST 
* SUMMARY
Possible CFData leak in CDMSessionAVFoundationCF.

This looks like a leak to me:

    RetainPtr<CFDataRef> keyRequest = AVCFAssetResourceLoadingRequestCreateStreamingContentKeyRequestDataForApp(...);

The naming of the method implies "Create" so I would expect an adoptCF() into the RetainPtr.
Comment 1 Brent Fulgham 2015-02-18 14:10:39 PST 
(In reply to comment #0)
> * SUMMARY
> Possible CFData leak in CDMSessionAVFoundationCF.
> 
> This looks like a leak to me:
> 
>     RetainPtr<CFDataRef> keyRequest =
> AVCFAssetResourceLoadingRequestCreateStreamingContentKeyRequestDataForApp(...
> );
> 
> The naming of the method implies "Create" so I would expect an adoptCF()
> into the RetainPtr.

I agree!
Comment 2 Radar WebKit Bug Importer 2015-02-18 14:11:30 PST 
<rdar://problem/19880286>
Comment 3 Brent Fulgham 2015-02-18 14:36:37 PST 
Created attachment 246849 [details]
Patch
Comment 4 Joseph Pecoraro 2015-02-18 15:20:46 PST 
Comment on attachment 246849 [details]
Patch

r=me! Thanks.
Comment 5 Brent Fulgham 2015-02-18 16:20:23 PST 
Committed r180324: <http://trac.webkit.org/changeset/180324>