Bug 141761 - Streamline unexported function build fixes
Summary: Streamline unexported function build fixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-18 11:39 PST by Alexey Proskuryakov
Modified: 2015-02-18 12:09 PST (History)
3 users (show)

See Also:

Attachments
proposed patch (4.14 KB, patch)
2015-02-18 11:44 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
proposed patch (6.74 KB, patch)
2015-02-18 11:46 PST, Alexey Proskuryakov 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-02-18 11:39:20 PST 
We don't need both an unexp file, and a special case in check-for-weak-vtables-andexternals.
Comment 1 Alexey Proskuryakov 2015-02-18 11:44:14 PST 
Created attachment 246831 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2015-02-18 11:46:36 PST 
Created attachment 246832 [details]
proposed patch

Forgot to include Tools changes.
Comment 3 Alexey Proskuryakov 2015-02-18 11:48:23 PST 
This is still a hack. It doesn't seem like we have any legitimate way to use the same name for a soft linked symbol, that's an ODR violation. Alex is going to switch to using a #define for that.
Comment 4 Alex Christensen 2015-02-18 11:53:45 PST 
Comment on attachment 246832 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246832&action=review

> Tools/Scripts/check-for-weak-vtables-and-externals:110
> +#    unlink $executablePath;

Get rid of this change
Comment 5 Alex Christensen 2015-02-18 12:09:37 PST 
http://trac.webkit.org/changeset/180282