Bug 141754 - Rename FontGlyphs to FontCascadeFonts
Summary: Rename FontGlyphs to FontCascadeFonts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-18 08:17 PST by Antti Koivisto
Modified: 2015-02-18 14:23 PST (History)
2 users (show)

See Also:

Attachments
patch (73.22 KB, patch)
2015-02-18 08:24 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (76.52 KB, patch)
2015-02-18 11:19 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
another (76.47 KB, patch)
2015-02-18 11:30 PST, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
patch (76.95 KB, patch)
2015-02-18 12:09 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
another (77.16 KB, patch)
2015-02-18 12:38 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-02-18 08:17:25 PST 
The name is misleading.
Comment 1 Antti Koivisto 2015-02-18 08:24:49 PST 
Created attachment 246816 [details]
patch

FontGlyphs -> FontCascadeFonts

Not a great name but the best I could come up with. FontCascadeImpl would be more vague.
Comment 2 Antti Koivisto 2015-02-18 11:19:29 PST 
Created attachment 246828 [details]
patch
Comment 3 Antti Koivisto 2015-02-18 11:30:58 PST 
Created attachment 246829 [details]
another
Comment 4 Andreas Kling 2015-02-18 12:04:40 PST 
Comment on attachment 246829 [details]
another

r=me :|

     1>..\platform\graphics\win\FontWin.cpp(30): fatal error C1083: Cannot open include file: 'FontGlyphs.h': No such file or directory
Comment 5 Antti Koivisto 2015-02-18 12:09:01 PST 
Created attachment 246836 [details]
patch
Comment 6 Antti Koivisto 2015-02-18 12:38:41 PST 
Created attachment 246841 [details]
another
Comment 7 WebKit Commit Bot 2015-02-18 14:23:35 PST 
Comment on attachment 246841 [details]
another

Clearing flags on attachment: 246841

Committed r180294: <http://trac.webkit.org/changeset/180294>
Comment 8 WebKit Commit Bot 2015-02-18 14:23:39 PST 
All reviewed patches have been landed.  Closing bug.